sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-03-01 00:46:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

Changed tests after rebasing on top of 7120e5da328

Browse Source 
That change made a few improvements, and uncovered a bug in handling
tables with composite primary keys if one component is an integer.
This commit is contained in:
José de Paula Rodrigues Neto Assis 2020-06-10 20:55:29 -03:00 committed by Nyall Dawson
parent 952542abf9
commit 2a2188e58b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/src/providers/testqgspostgresprovider.cpp
View File

@ -256,7 +256,7 @@ void TestQgsPostgresProvider::testQuotedValueBigInt()
sdata = new QgsPostgresSharedData;
sdata->insertFid( 1LL, vlst );
QCOMPARE( QgsPostgresUtils::whereClause( 1LL, fields, NULL, QgsPostgresPrimaryKeyType::PktFidMap, pkAttrs, std::shared_ptr<QgsPostgresSharedData>( sdata ) ), QString( "\"fld_double\"::text='3.141592741'" ) );
QCOMPARE( QgsPostgresUtils::whereClause( 1LL, fields, NULL, QgsPostgresPrimaryKeyType::PktFidMap, pkAttrs, std::shared_ptr<QgsPostgresSharedData>( sdata ) ), QString( "\"fld_double\"=3.141592741" ) );
// text
f3.setName( "fld_text" );
@ -296,9 +296,9 @@ void TestQgsPostgresProvider::testQuotedValueBigInt()
sdata = new QgsPostgresSharedData;
sdata->insertFid( 1LL, vlst );
// TODO: FIXME: Please don't cast integer primary key types to text if they are part of a FidMap!
// TODO: FIXME: in tables with composite PKs, integer fields are cast to text, but their values are not.
// It hurts the database performance badly.
QCOMPARE( QgsPostgresUtils::whereClause( 1LL, fields, NULL, QgsPostgresPrimaryKeyType::PktFidMap, pkAttrs, std::shared_ptr<QgsPostgresSharedData>( sdata ) ), QString( "\"fld_bigint\"='-9223372036854775800' AND \"fld_text\"::text='QGIS ''Rocks''!' AND \"fld_integer\"::text='42'" ) );
QCOMPARE( QgsPostgresUtils::whereClause( 1LL, fields, NULL, QgsPostgresPrimaryKeyType::PktFidMap, pkAttrs, std::shared_ptr<QgsPostgresSharedData>( sdata ) ), QString( "\"fld_bigint\"=-9223372036854775800 AND \"fld_text\"::text='QGIS ''Rocks''!' AND \"fld_integer\"::text=42" ) );
}
QGSTEST_MAIN( TestQgsPostgresProvider )