buxfixes

- use useIntersects in identify (fixes #1251)
- clear node list of identify results on new identify (fixes #1252)
- use feature copies for split features and identify


git-svn-id: http://svn.osgeo.org/qgis/trunk@9209 c8812cc2-4d05-0410-92ff-de0c093fc19c

src/app/qgsidentifyresults.cpp

@@ -164,8 +164,7 @@ void QgsIdentifyResults::addDerivedAttribute( QTreeWidgetItem * fnode, QString f
 {
   QTreeWidgetItem * daRootNode;
 
-  // Determine if this is the first derived attribute for this
+  // Determine if this is the first derived attribute for this feature or not
-  // feature or not
   if ( mDerivedAttributeRootNodes.find( fnode ) != mDerivedAttributeRootNodes.end() )
   {
     // Reuse existing derived-attribute root node
@@ -243,6 +242,7 @@ void QgsIdentifyResults::expandColumnsToFit()
 
 void QgsIdentifyResults::clear()
 {
+  mDerivedAttributeRootNodes.clear();
   lstResults->clear();
 }
 

src/app/qgsmaptoolidentify.cpp

@@ -263,10 +263,10 @@ void QgsMapToolIdentify::identifyVectorLayer( const QgsPoint& point )
   mFeatureList.clear();
   QApplication::setOverrideCursor( Qt::WaitCursor );
 
-  layer->select( layer->pendingAllAttributesList(), r, true );
+  layer->select( layer->pendingAllAttributesList(), r, true, true );
   QgsFeature f;
   while ( layer->getNextFeature( f ) )
-    mFeatureList << f;
+    mFeatureList << QgsFeature(f);
 
   QApplication::restoreOverrideCursor();
 

src/core/qgsvectorlayer.cpp

@@ -1715,7 +1715,7 @@ int QgsVectorLayer::splitFeatures( const QList<QgsPoint>& splitLine, bool topolo
 
     QgsFeature f;
     while ( getNextFeature( f ) )
-      featureList << f;
+      featureList << QgsFeature(f);
   }
 
   QgsFeatureList::iterator select_it = featureList.begin();