From 0fcb4cc7d5467af26a1333ae9566cbda5058a10c Mon Sep 17 00:00:00 2001 From: Nyall Dawson Date: Wed, 25 Jun 2025 12:57:44 +1000 Subject: [PATCH] Revert "[Tests] Disable 7 tests that break due to expired certificate" This reverts commit 47576382adeea10d5392bd36d1fcc277d6172496. --- tests/src/core/testqgsauthcertutils.cpp | 3 --- tests/src/core/testqgsauthconfig.cpp | 3 --- tests/src/python/test_qgsauthsystem.py | 15 --------------- 3 files changed, 21 deletions(-) diff --git a/tests/src/core/testqgsauthcertutils.cpp b/tests/src/core/testqgsauthcertutils.cpp index 361d38ffeb9..3d440246c4f 100644 --- a/tests/src/core/testqgsauthcertutils.cpp +++ b/tests/src/core/testqgsauthcertutils.cpp @@ -64,9 +64,6 @@ void TestQgsAuthCertUtils::cleanupTestCase() void TestQgsAuthCertUtils::testValidationUtils() { - // FIXME - QSKIP( "Broken test. See https://github.com/qgis/QGIS/issues/62373", SkipSingle ); - // null cert QSslCertificate cert; QVERIFY( !QgsAuthCertUtils::certIsCurrent( cert ) ); diff --git a/tests/src/core/testqgsauthconfig.cpp b/tests/src/core/testqgsauthconfig.cpp index 6dfc6c29c63..1d2600b6228 100644 --- a/tests/src/core/testqgsauthconfig.cpp +++ b/tests/src/core/testqgsauthconfig.cpp @@ -125,9 +125,6 @@ void TestQgsAuthConfig::testMethodConfig() void TestQgsAuthConfig::testPkiBundle() { - // FIXME - QSKIP( "Broken test. See https://github.com/qgis/QGIS/issues/62373", SkipSingle ); - QgsPkiBundle bundle; QVERIFY( bundle.isNull() ); QVERIFY( !bundle.isValid() ); diff --git a/tests/src/python/test_qgsauthsystem.py b/tests/src/python/test_qgsauthsystem.py index 47a344f23dc..07591b33f45 100644 --- a/tests/src/python/test_qgsauthsystem.py +++ b/tests/src/python/test_qgsauthsystem.py @@ -147,9 +147,6 @@ class TestQgsAuthManager(QgisTestCase): def test_040_authorities(self): - # FIXME - self.skipTest("Broken test. See https://github.com/qgis/QGIS/issues/62373") - def rebuild_caches(): m = "Authorities cache could not be rebuilt" self.assertTrue(self.authm.rebuildCaCertsCache(), m) @@ -663,9 +660,6 @@ class TestQgsAuthManager(QgisTestCase): def test_150_verify_keychain(self): """Test the verify keychain function""" - # FIXME - self.skipTest("Broken test. See https://github.com/qgis/QGIS/issues/62373") - def testChain(path): # Test that a chain with an untrusted CA is not valid @@ -742,9 +736,6 @@ class TestQgsAuthManager(QgisTestCase): def test_validate_pki_bundle(self): """Text the pki bundle validation""" - # FIXME - self.skipTest("Broken test. See https://github.com/qgis/QGIS/issues/62373") - # Valid bundle: bundle = self.mkPEMBundle( "fra_cert.pem", "fra_key.pem", "password", "chain_subissuer-issuer-root.pem" @@ -936,9 +927,6 @@ class TestQgsAuthManager(QgisTestCase): def test_160_cert_viable(self): """Text the viability of a given certificate""" - # FIXME - self.skipTest("Broken test. See https://github.com/qgis/QGIS/issues/62373") - # null cert cert = QSslCertificate() self.assertFalse(QgsAuthCertUtils.certIsCurrent(cert)) @@ -968,9 +956,6 @@ class TestQgsAuthManager(QgisTestCase): def test_170_pki_key_encoding(self): """Test that a DER/PEM RSA/DSA/EC keys can be opened whatever the extension is""" - # FIXME - self.skipTest("Broken test. See https://github.com/qgis/QGIS/issues/62373") - self.assertFalse( QgsAuthCertUtils.keyFromFile(PKIDATA + "/" + "ptolemy_key.pem").isNull() )