Address review

This commit is contained in:
Mathieu Pellerin 2024-03-11 09:32:40 +07:00
parent 1c6bb926ad
commit 0995197eb6
5 changed files with 10 additions and 10 deletions

View File

@ -246,7 +246,7 @@ Sets the baudrate of the serial port the sensor connects to.
QByteArray delimiter() const;
%Docstring
Returns the current delimiter used to separate data frames. If empty,
each serial port data updates will be considered a data frame.
each serial port data update will be considered a data frame.
.. versionadded:: 3.38
%End
@ -254,7 +254,7 @@ each serial port data updates will be considered a data frame.
void setDelimiter( const QByteArray &delimiter );
%Docstring
Sets the delimiter used to identify data frames out of the data received
from the serial port. If empty, each serial port data updates will be
from the serial port. If empty, each serial port data update will be
considered a data frame.
:param delimiter: Character used to identify data frames

View File

@ -246,7 +246,7 @@ Sets the baudrate of the serial port the sensor connects to.
QByteArray delimiter() const;
%Docstring
Returns the current delimiter used to separate data frames. If empty,
each serial port data updates will be considered a data frame.
each serial port data update will be considered a data frame.
.. versionadded:: 3.38
%End
@ -254,7 +254,7 @@ each serial port data updates will be considered a data frame.
void setDelimiter( const QByteArray &delimiter );
%Docstring
Sets the delimiter used to identify data frames out of the data received
from the serial port. If empty, each serial port data updates will be
from the serial port. If empty, each serial port data update will be
considered a data frame.
:param delimiter: Character used to identify data frames

View File

@ -276,14 +276,14 @@ class CORE_EXPORT QgsSerialPortSensor : public QgsIODeviceSensor
/**
* Returns the current delimiter used to separate data frames. If empty,
* each serial port data updates will be considered a data frame.
* each serial port data update will be considered a data frame.
* \since QGIS 3.38
*/
QByteArray delimiter() const;
/**
* Sets the delimiter used to identify data frames out of the data received
* from the serial port. If empty, each serial port data updates will be
* from the serial port. If empty, each serial port data update will be
* considered a data frame.
* \param delimiter Character used to identify data frames
* \since QGIS 3.38

View File

@ -157,9 +157,9 @@ QgsSerialPortSensorWidget::QgsSerialPortSensorWidget( QWidget *parent )
mBaudRateComboBox->addItem( QStringLiteral( "115200 baud" ), static_cast<int>( QSerialPort::Baud115200 ) );
mBaudRateComboBox->setCurrentIndex( 3 );
mDataFrameDelimiterComboBox->addItem( tr( "No delimiter" ), QString() );
mDataFrameDelimiterComboBox->addItem( tr( "New line" ), QString( "\n" ) );
mDataFrameDelimiterComboBox->addItem( tr( "Custom character" ), QString() );
mDataFrameDelimiterComboBox->addItem( tr( "No Delimiter" ), QString() );
mDataFrameDelimiterComboBox->addItem( tr( "New Line" ), QString( "\n" ) );
mDataFrameDelimiterComboBox->addItem( tr( "Custom Character" ), QString() );
updateSerialPortDetails();

View File

@ -96,7 +96,7 @@
</sizepolicy>
</property>
<property name="toolTip">
<string>Choose a character acting as data frame delimiter</string>
<string>Choose a character to act as the data frame delimiter</string>
</property>
</widget>
</item>