sharpetronics/QGIS
1
0
Fork 0
mirror of https://github.com/qgis/QGIS.git synced 2025-10-18 00:06:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #54141 : increase expression widget text size for long expressions

Browse Source
This commit is contained in:
Julien Cabieces 2023-10-25 17:40:05 +02:00 committed by Nyall Dawson
parent 8b4b87f639
commit 044809cd46
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/gui/qgsfieldexpressionwidget.cpp
View File

@ -190,6 +190,11 @@ void QgsFieldExpressionWidget::setField( const QString &fieldName )
return; return;
} }
if ( fieldName.size() > mCombo->lineEdit()->maxLength() )
{
mCombo->lineEdit()->setMaxLength( fieldName.size() );
}
QModelIndex idx = mFieldProxyModel->sourceFieldModel()->indexFromName( fieldName ); QModelIndex idx = mFieldProxyModel->sourceFieldModel()->indexFromName( fieldName );
if ( !idx.isValid() ) if ( !idx.isValid() )
{ {

15
tests/src/gui/testqgsfieldexpressionwidget.cpp
View File

@ -49,6 +49,7 @@ class TestQgsFieldExpressionWidget : public QObject
void testIsValid(); void testIsValid();
void testFilters(); void testFilters();
void setNull(); void setNull();
void testVeryLongExpression();
private: private:
QgsFieldExpressionWidget *mWidget = nullptr; QgsFieldExpressionWidget *mWidget = nullptr;
@ -372,5 +373,19 @@ void TestQgsFieldExpressionWidget::setNull()
QgsProject::instance()->removeMapLayer( layer ); QgsProject::instance()->removeMapLayer( layer );
} }
void TestQgsFieldExpressionWidget::testVeryLongExpression()
{
QString veryLongExpression;
for ( int i = 0; i < 32770; i++ )
{
veryLongExpression += "a";
}
mWidget->setExpression( veryLongExpression );
QCOMPARE( veryLongExpression.size(), mWidget->currentText().size() );
};
QGSTEST_MAIN( TestQgsFieldExpressionWidget ) QGSTEST_MAIN( TestQgsFieldExpressionWidget )
#include "testqgsfieldexpressionwidget.moc" #include "testqgsfieldexpressionwidget.moc"