mirror of
https://github.com/postgres/postgres.git
synced 2025-11-04 00:02:52 -05:00
7c17aac69d
When adding replication origins in 5aa235042, I somehow managed to set the timestamp of decoded transactions to InvalidXLogRecptr when decoding one made without a replication origin. Fix that, and the wrong type of the new commit_time variable. This didn't trigger a regression test failure because we explicitly don't show commit timestamps in the regression tests, as they obviously are variable. Add a test that checks that a decoded commit's timestamp is within minutes of NOW() from before the commit. Reported-By: Weiping Qu Diagnosed-By: Artur Zakirov Discussion: 56D4197E.9050706@informatik.uni-kl.de, 56D42918.1010108@postgrespro.ru Backpatch: 9.5, where 5aa235042 originates.
41 lines
1.2 KiB
Plaintext
41 lines
1.2 KiB
Plaintext
SET synchronous_commit = on;
|
|
CREATE TABLE test_time(data text);
|
|
-- remember the current time
|
|
SELECT set_config('test.time_before', NOW()::text, false) IS NOT NULL;
|
|
?column?
|
|
----------
|
|
t
|
|
(1 row)
|
|
|
|
SELECT 'init' FROM pg_create_logical_replication_slot('regression_slot', 'test_decoding');
|
|
?column?
|
|
----------
|
|
init
|
|
(1 row)
|
|
|
|
-- a single transaction, to get the commit time
|
|
INSERT INTO test_time(data) VALUES ('');
|
|
-- parse the commit time from the changeset
|
|
SELECT set_config('test.time_after', regexp_replace(data, '^COMMIT \(at (.*)\)$', '\1'), false) IS NOT NULL
|
|
FROM pg_logical_slot_peek_changes('regression_slot', NULL, NULL, 'include-xids', '0', 'skip-empty-xacts', '1', 'include-timestamp', '1')
|
|
WHERE data ~ 'COMMIT' LIMIT 1;
|
|
?column?
|
|
----------
|
|
t
|
|
(1 row)
|
|
|
|
-- ensure commit time is sane in relation to the previous time
|
|
SELECT (time_after - time_before) <= '10 minutes'::interval, time_after >= time_before
|
|
FROM (SELECT current_setting('test.time_after')::timestamptz AS time_after, (SELECT current_setting('test.time_before')::timestamptz) AS time_before) AS d;
|
|
?column? | ?column?
|
|
----------+----------
|
|
t | t
|
|
(1 row)
|
|
|
|
SELECT pg_drop_replication_slot('regression_slot');
|
|
pg_drop_replication_slot
|
|
--------------------------
|
|
|
|
(1 row)
|
|
|