mirror of
https://github.com/postgres/postgres.git
synced 2025-10-29 00:05:29 -04:00
811b6e36a9
Some error messages related to file handling are using the code path context to define their state. For example, 2PC-related errors are referring to "two-phase status files", or "relation mapping file" is used for catalog-to-filenode mapping, however those prove to be difficult to translate, and are not more helpful than just referring to the path of the file being worked on. So simplify all those error messages by just referring to files with their path used. In some cases, like the manipulation of WAL segments, the context is actually helpful so those are kept. Calls to the system function read() have also been rather inconsistent with their error handling sometimes not reporting the number of bytes read, and some other code paths trying to use an errno which has not been set. The in-core functions are using a more consistent pattern with this patch, which checks for both errno if set or if an inconsistent read is happening. So as to care about pluralization when reading an unexpected number of byte(s), "could not read: read %d of %zu" is used as error message, with %d field being the output result of read() and %zu the expected size. This simplifies the work of translators with less variations of the same message. Author: Michael Paquier Reviewed-by: Álvaro Herrera Discussion: https://postgr.es/m/20180520000522.GB1603@paquier.xyz
122 lines
3.1 KiB
C
122 lines
3.1 KiB
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* controldata_utils.c
|
|
* Common code for control data file output.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2018, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
*
|
|
* IDENTIFICATION
|
|
* src/common/controldata_utils.c
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
|
|
#ifndef FRONTEND
|
|
#include "postgres.h"
|
|
#else
|
|
#include "postgres_fe.h"
|
|
#endif
|
|
|
|
#include <unistd.h>
|
|
#include <sys/stat.h>
|
|
#include <fcntl.h>
|
|
|
|
#include "catalog/pg_control.h"
|
|
#include "common/controldata_utils.h"
|
|
#include "port/pg_crc32c.h"
|
|
|
|
/*
|
|
* get_controlfile(char *DataDir, const char *progname, bool *crc_ok_p)
|
|
*
|
|
* Get controlfile values. The result is returned as a palloc'd copy of the
|
|
* control file data.
|
|
*
|
|
* crc_ok_p can be used by the caller to see whether the CRC of the control
|
|
* file data is correct.
|
|
*/
|
|
ControlFileData *
|
|
get_controlfile(const char *DataDir, const char *progname, bool *crc_ok_p)
|
|
{
|
|
ControlFileData *ControlFile;
|
|
int fd;
|
|
char ControlFilePath[MAXPGPATH];
|
|
pg_crc32c crc;
|
|
int r;
|
|
|
|
AssertArg(crc_ok_p);
|
|
|
|
ControlFile = palloc(sizeof(ControlFileData));
|
|
snprintf(ControlFilePath, MAXPGPATH, "%s/global/pg_control", DataDir);
|
|
|
|
if ((fd = open(ControlFilePath, O_RDONLY | PG_BINARY, 0)) == -1)
|
|
#ifndef FRONTEND
|
|
ereport(ERROR,
|
|
(errcode_for_file_access(),
|
|
errmsg("could not open file \"%s\" for reading: %m",
|
|
ControlFilePath)));
|
|
#else
|
|
{
|
|
fprintf(stderr, _("%s: could not open file \"%s\" for reading: %s\n"),
|
|
progname, ControlFilePath, strerror(errno));
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
#endif
|
|
|
|
r = read(fd, ControlFile, sizeof(ControlFileData));
|
|
if (r != sizeof(ControlFileData))
|
|
{
|
|
if (r < 0)
|
|
#ifndef FRONTEND
|
|
ereport(ERROR,
|
|
(errcode_for_file_access(),
|
|
errmsg("could not read file \"%s\": %m", ControlFilePath)));
|
|
#else
|
|
{
|
|
fprintf(stderr, _("%s: could not read file \"%s\": %s\n"),
|
|
progname, ControlFilePath, strerror(errno));
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
#endif
|
|
else
|
|
#ifndef FRONTEND
|
|
ereport(ERROR,
|
|
(errmsg("could not read file \"%s\": read %d of %zu",
|
|
ControlFilePath, r, sizeof(ControlFileData))));
|
|
#else
|
|
{
|
|
fprintf(stderr, _("%s: could not read file \"%s\": read %d of %zu\n"),
|
|
progname, ControlFilePath, r, sizeof(ControlFileData));
|
|
exit(EXIT_FAILURE);
|
|
}
|
|
#endif
|
|
}
|
|
|
|
close(fd);
|
|
|
|
/* Check the CRC. */
|
|
INIT_CRC32C(crc);
|
|
COMP_CRC32C(crc,
|
|
(char *) ControlFile,
|
|
offsetof(ControlFileData, crc));
|
|
FIN_CRC32C(crc);
|
|
|
|
*crc_ok_p = EQ_CRC32C(crc, ControlFile->crc);
|
|
|
|
/* Make sure the control file is valid byte order. */
|
|
if (ControlFile->pg_control_version % 65536 == 0 &&
|
|
ControlFile->pg_control_version / 65536 != 0)
|
|
#ifndef FRONTEND
|
|
elog(ERROR, _("byte ordering mismatch"));
|
|
#else
|
|
printf(_("WARNING: possible byte ordering mismatch\n"
|
|
"The byte ordering used to store the pg_control file might not match the one\n"
|
|
"used by this program. In that case the results below would be incorrect, and\n"
|
|
"the PostgreSQL installation would be incompatible with this data directory.\n"));
|
|
#endif
|
|
|
|
return ControlFile;
|
|
}
|