mirror of
https://github.com/postgres/postgres.git
synced 2025-11-20 00:02:24 -05:00
21f428ebde
Instead of calling pg_lsn_in() in check_recovery_target_lsn and timestamptz_in() in check_recovery_target_time, reorganize the respective code so that we don't raise any errors in the check hooks. The previous code tried to use PG_TRY/PG_CATCH to handle errors in a way that is not safe, so now the code contains no ereport() calls and can operate safely within the GUC error handling system. Moreover, since the interpretation of the recovery_target_time string may depend on the time zone, we cannot do the final processing of that string until all the GUC processing is done. Instead, check_recovery_target_time() now does some parsing for syntax checking, but the actual conversion to a timestamptz value is done later in the recovery code that uses it. Reported-by: Andres Freund <andres@anarazel.de> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://www.postgresql.org/message-id/flat/20190611061115.njjwkagvxp4qujhp%40alap3.anarazel.de
30 lines
840 B
C
30 lines
840 B
C
/*-------------------------------------------------------------------------
|
|
*
|
|
* pg_lsn.h
|
|
* Declarations for operations on log sequence numbers (LSNs) of
|
|
* PostgreSQL.
|
|
*
|
|
*
|
|
* Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
|
|
* Portions Copyright (c) 1994, Regents of the University of California
|
|
*
|
|
* src/include/utils/pg_lsn.h
|
|
*
|
|
*-------------------------------------------------------------------------
|
|
*/
|
|
#ifndef PG_LSN_H
|
|
#define PG_LSN_H
|
|
|
|
#include "fmgr.h"
|
|
#include "access/xlogdefs.h"
|
|
|
|
#define DatumGetLSN(X) ((XLogRecPtr) DatumGetInt64(X))
|
|
#define LSNGetDatum(X) (Int64GetDatum((int64) (X)))
|
|
|
|
#define PG_GETARG_LSN(n) DatumGetLSN(PG_GETARG_DATUM(n))
|
|
#define PG_RETURN_LSN(x) return LSNGetDatum(x)
|
|
|
|
extern XLogRecPtr pg_lsn_in_internal(const char *str, bool *have_error);
|
|
|
|
#endif /* PG_LSN_H */
|