Follow-up fixes for "Make all Perl warnings fatal"

Mostly, we need to check whether $ENV{PG_TEST_EXTRA} is set before
doing regular expression matches against it.

config/check_modules.pl

@@ -5,7 +5,7 @@
 # but specify them anyway for documentation's sake.)
 #
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use Config;
 
 use IPC::Run 0.79;

contrib/amcheck/t/001_verify_heapam.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/amcheck/t/002_cic.pl

@@ -3,7 +3,7 @@
 
 # Test CREATE INDEX CONCURRENTLY with concurrent modifications
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/amcheck/t/003_cic_2pc.pl

@@ -3,7 +3,7 @@
 
 # Test CREATE INDEX CONCURRENTLY with concurrent prepared-xact modifications
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/amcheck/t/004_verify_nbtree_unique.pl

@@ -5,7 +5,7 @@
 # presence of breaking sort order changes.
 #
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

contrib/amcheck/t/005_pitr.pl

@@ -2,7 +2,7 @@
 
 # Test integrity of intermediate states by PITR to those states
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

contrib/auto_explain/t/001_auto_explain.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/basebackup_to_shell/t/001_basic.pl

@@ -1,7 +1,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/bloom/t/001_wal.pl

@@ -3,7 +3,7 @@
 
 # Test generic xlog record work for bloom index replication.
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

contrib/fuzzystrmatch/daitch_mokotoff_header.pl

@@ -9,7 +9,7 @@
 #
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 die "Usage: $0 OUTPUT_FILE\n" if @ARGV != 1;
 my $output_file = $ARGV[0];

contrib/intarray/bench/bench.pl

@@ -3,7 +3,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 # make sure we are in a sane environment.
 use DBI();

contrib/intarray/bench/create_test.pl

@@ -5,7 +5,7 @@
 # contrib/intarray/bench/create_test.pl
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 print <<EOT;
 create table message (

contrib/oid2name/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Utils;
 use Test::More;

contrib/pg_prewarm/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/seg/seg-validate.pl

@@ -3,7 +3,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 my $integer = '[+-]?[0-9]+';
 my $real = '[+-]?[0-9]+\.[0-9]+';

contrib/seg/sort-segments.pl

@@ -5,7 +5,7 @@
 # this script will sort any table with the segment data type in its last column
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 my @rows;
 

contrib/test_decoding/t/001_repl_stats.pl

@@ -4,7 +4,7 @@
 # Test replication statistics data in pg_stat_replication_slots is sane after
 # drop replication slot and restart.
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Path qw(rmtree);
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

contrib/vacuumlo/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Utils;
 use Test::More;

doc/src/sgml/generate-errcodes-table.pl

@@ -4,7 +4,7 @@
 # Copyright (c) 2000-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 print
   "<!-- autogenerated from src/backend/utils/errcodes.txt, do not edit -->\n";

doc/src/sgml/generate-keywords-table.pl

@@ -5,7 +5,7 @@
 # Copyright (c) 2019-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 my @sql_versions = reverse sort ('1992', '2016', '2023');
 

doc/src/sgml/generate-targets-meson.pl

@@ -4,7 +4,7 @@
 # Copyright (c) 2000-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 my $targets_meson_file = $ARGV[0];
 open my $targets_meson, '<', $targets_meson_file or die;

doc/src/sgml/mk_feature_tables.pl

@@ -3,7 +3,7 @@
 # doc/src/sgml/mk_feature_tables.pl
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 my $yesno = $ARGV[0];
 

src/backend/catalog/Catalog.pm

@@ -14,7 +14,7 @@
 package Catalog;
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use File::Compare;
 

src/backend/catalog/genbki.pl

@@ -14,7 +14,7 @@
 #----------------------------------------------------------------------
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use Getopt::Long;
 
 use FindBin;

src/backend/nodes/gen_node_support.pl

@@ -16,7 +16,7 @@
 #----------------------------------------------------------------------
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use File::Basename;
 use Getopt::Long;

src/backend/parser/check_keywords.pl

@@ -7,7 +7,7 @@
 # Copyright (c) 2009-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 my $gram_filename = $ARGV[0];
 my $kwlist_filename = $ARGV[1];

src/backend/snowball/snowball_create.pl

@@ -1,7 +1,7 @@
 #!/usr/bin/perl
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use Getopt::Long;
 
 my $outdir_path = '';

src/backend/storage/lmgr/generate-lwlocknames.pl

@@ -4,7 +4,7 @@
 # Copyright (c) 2000-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use Getopt::Long;
 
 my $output_path = '.';

src/backend/utils/Gen_dummy_probes.pl

@@ -7,7 +7,7 @@
 #-------------------------------------------------------------------------
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 m/^\s*probe / || next;
 s/^\s*probe ([^(]*)(.*);/$1$2/;

src/backend/utils/Gen_fmgrtab.pl

@@ -17,7 +17,7 @@
 use Catalog;
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use Getopt::Long;
 
 my $output_path = '';

src/backend/utils/activity/generate-wait_event_types.pl

@@ -15,7 +15,7 @@
 #----------------------------------------------------------------------
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use Getopt::Long;
 
 my $output_path = '.';

src/backend/utils/generate-errcodes.pl

@@ -4,7 +4,7 @@
 # Copyright (c) 2000-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use Getopt::Long;
 
 my $outfile = '';

src/backend/utils/mb/Unicode/UCS_to_BIG5.pl

@@ -25,7 +25,7 @@
 #		 # and Unicode name (not used in this script)
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_EUC_CN.pl

@@ -14,7 +14,7 @@
 # and the "b" field is the hex byte sequence for GB18030
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_EUC_JIS_2004.pl

@@ -8,7 +8,7 @@
 # "euc-jis-2004-std.txt" (http://x0213.org)
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_EUC_JP.pl

@@ -12,7 +12,7 @@
 # organization's ftp site.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_EUC_KR.pl

@@ -17,7 +17,7 @@
 #		 # and Unicode name (not used in this script)
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_EUC_TW.pl

@@ -18,7 +18,7 @@
 #		 # and Unicode name (not used in this script)
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_GB18030.pl

@@ -14,7 +14,7 @@
 # and the "b" field is the hex byte sequence for GB18030
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_JOHAB.pl

@@ -16,7 +16,7 @@
 #		 # and Unicode name (not used in this script)
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_SHIFT_JIS_2004.pl

@@ -8,7 +8,7 @@
 # "sjis-0213-2004-std.txt" (http://x0213.org)
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_SJIS.pl

@@ -11,7 +11,7 @@
 # ftp site.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_UHC.pl

@@ -14,7 +14,7 @@
 # and the "b" field is the hex byte sequence for UHC
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/UCS_to_most.pl

@@ -16,7 +16,7 @@
 #		 # and Unicode name (not used in this script)
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use convutils;
 

src/backend/utils/mb/Unicode/convutils.pm

@@ -6,7 +6,7 @@
 package convutils;
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use Carp;
 use Exporter 'import';

src/bin/initdb/t/001_initdb.pl

@@ -6,7 +6,7 @@
 # Successful initdb consumes much time and I/O.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use Fcntl ':mode';
 use File::stat qw{lstat};
 use PostgreSQL::Test::Cluster;

src/bin/pg_amcheck/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Utils;
 use Test::More;

src/bin/pg_amcheck/t/002_nonesuch.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_amcheck/t/003_check.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_amcheck/t/004_verify_heapam.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_amcheck/t/005_opclass_damage.pl

@@ -5,7 +5,7 @@
 # presence of breaking sort order changes.
 #
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

src/bin/pg_archivecleanup/t/010_pg_archivecleanup.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_basebackup/t/010_pg_basebackup.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Basename qw(basename dirname);
 use File::Path     qw(rmtree);
 use PostgreSQL::Test::Cluster;

src/bin/pg_basebackup/t/011_in_place_tablespace.pl

@@ -1,7 +1,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

src/bin/pg_basebackup/t/020_pg_receivewal.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use PostgreSQL::Test::Cluster;
 use Test::More;

src/bin/pg_basebackup/t/030_pg_recvlogical.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use PostgreSQL::Test::Cluster;
 use Test::More;

src/bin/pg_checksums/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_checksums/t/002_actions.pl

@@ -5,7 +5,7 @@
 # an initialized cluster.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 

src/bin/pg_combinebackup/t/001_basic.pl

@@ -1,7 +1,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_combinebackup/t/002_compare_backups.pl

@@ -1,7 +1,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Compare;
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_combinebackup/t/003_timeline.pl

@@ -4,7 +4,7 @@
 # properly even when the reference backup is on a different timeline.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Compare;
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_combinebackup/t/004_manifest.pl

@@ -6,7 +6,7 @@
 # pg_combinebackup does not produce a manifest when run with --no-manifest.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Compare;
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_combinebackup/t/005_integrity.pl

@@ -5,7 +5,7 @@
 # prior backup.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Compare;
 use File::Path qw(rmtree);
 use PostgreSQL::Test::Cluster;

src/bin/pg_config/t/001_pg_config.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_controldata/t/001_pg_controldata.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

src/bin/pg_ctl/t/001_start_stop.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_ctl/t/002_status.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_ctl/t/003_promote.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_ctl/t/004_logrotate.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_dump/pg_dump.c

@@ -2046,6 +2046,26 @@ selectDumpablePublicationObject(DumpableObject *dobj, Archive *fout)
 		DUMP_COMPONENT_ALL : DUMP_COMPONENT_NONE;
 }
 
+/*
+ * selectDumpableStatisticsObject: policy-setting subroutine
+ *		Mark an extended statistics object as to be dumped or not
+ *
+ * We dump an extended statistics object if the schema it's in and the table
+ * it's for are being dumped.  (This'll need more thought if statistics
+ * objects ever support cross-table stats.)
+ */
+static void
+selectDumpableStatisticsObject(StatsExtInfo *sobj, Archive *fout)
+{
+	if (checkExtensionMembership(&sobj->dobj, fout))
+		return;					/* extension membership overrides all else */
+
+	sobj->dobj.dump = sobj->dobj.namespace->dobj.dump_contains;
+	if (sobj->stattable == NULL ||
+		!(sobj->stattable->dobj.dump & DUMP_COMPONENT_DEFINITION))
+		sobj->dobj.dump = DUMP_COMPONENT_NONE;
+}
+
 /*
  * selectDumpableObject: policy-setting subroutine
  *		Mark a generic dumpable object as to be dumped or not
@@ -7291,6 +7311,7 @@ getExtendedStatistics(Archive *fout)
 	int			i_stxname;
 	int			i_stxnamespace;
 	int			i_stxowner;
+	int			i_stxrelid;
 	int			i_stattarget;
 	int			i;
 
@@ -7302,11 +7323,11 @@ getExtendedStatistics(Archive *fout)
 
 	if (fout->remoteVersion < 130000)
 		appendPQExpBufferStr(query, "SELECT tableoid, oid, stxname, "
-							 "stxnamespace, stxowner, (-1) AS stxstattarget "
+							 "stxnamespace, stxowner, stxrelid, (-1) AS stxstattarget "
 							 "FROM pg_catalog.pg_statistic_ext");
 	else
 		appendPQExpBufferStr(query, "SELECT tableoid, oid, stxname, "
-							 "stxnamespace, stxowner, stxstattarget "
+							 "stxnamespace, stxowner, stxrelid, stxstattarget "
 							 "FROM pg_catalog.pg_statistic_ext");
 
 	res = ExecuteSqlQuery(fout, query->data, PGRES_TUPLES_OK);
@@ -7318,6 +7339,7 @@ getExtendedStatistics(Archive *fout)
 	i_stxname = PQfnumber(res, "stxname");
 	i_stxnamespace = PQfnumber(res, "stxnamespace");
 	i_stxowner = PQfnumber(res, "stxowner");
+	i_stxrelid = PQfnumber(res, "stxrelid");
 	i_stattarget = PQfnumber(res, "stxstattarget");
 
 	statsextinfo = (StatsExtInfo *) pg_malloc(ntups * sizeof(StatsExtInfo));
@@ -7332,10 +7354,12 @@ getExtendedStatistics(Archive *fout)
 		statsextinfo[i].dobj.namespace =
 			findNamespace(atooid(PQgetvalue(res, i, i_stxnamespace)));
 		statsextinfo[i].rolname = getRoleName(PQgetvalue(res, i, i_stxowner));
+		statsextinfo[i].stattable =
+			findTableByOid(atooid(PQgetvalue(res, i, i_stxrelid)));
 		statsextinfo[i].stattarget = atoi(PQgetvalue(res, i, i_stattarget));
 
 		/* Decide whether we want to dump it */
-		selectDumpableObject(&(statsextinfo[i].dobj), fout);
+		selectDumpableStatisticsObject(&(statsextinfo[i]), fout);
 	}
 
 	PQclear(res);

src/bin/pg_dump/pg_dump.h

@@ -423,7 +423,8 @@ typedef struct _indexAttachInfo
 typedef struct _statsExtInfo
 {
 	DumpableObject dobj;
-	const char *rolname;
+	const char *rolname;		/* owner */
+	TableInfo  *stattable;		/* link to table the stats are for */
 	int			stattarget;		/* statistics target */
 } StatsExtInfo;
 

src/bin/pg_dump/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_dump/t/002_pg_dump.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
@@ -3742,14 +3742,15 @@ my %tests = (
 	'CREATE STATISTICS extended_stats_no_options' => {
 		create_order => 97,
 		create_sql => 'CREATE STATISTICS dump_test.test_ext_stats_no_options
-							ON col1, col2 FROM dump_test.test_fifth_table',
+							ON col1, col2 FROM dump_test.test_table',
 		regexp => qr/^
-			\QCREATE STATISTICS dump_test.test_ext_stats_no_options ON col1, col2 FROM dump_test.test_fifth_table;\E
+			\QCREATE STATISTICS dump_test.test_ext_stats_no_options ON col1, col2 FROM dump_test.test_table;\E
 		    /xms,
 		like =>
 		  { %full_runs, %dump_test_schema_runs, section_post_data => 1, },
 		unlike => {
 			exclude_dump_test_schema => 1,
+			exclude_test_table => 1,
 			only_dump_measurement => 1,
 		},
 	},

src/bin/pg_dump/t/003_pg_dump_with_server.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_dump/t/004_pg_dump_parallel.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_dump/t/005_pg_dump_filterfile.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_dump/t/010_dump_connstr.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_resetwal/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_resetwal/t/002_corrupted.pl

@@ -4,7 +4,7 @@
 # Tests for handling a corrupted pg_control
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_rewind/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_rewind/t/002_databases.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_rewind/t/003_extrafiles.pl

@@ -4,7 +4,7 @@
 # Test how pg_rewind reacts to extra files and directories in the data dirs.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_rewind/t/004_pg_xlog_symlink.pl

@@ -5,7 +5,7 @@
 # Test pg_rewind when the target's pg_wal directory is a symlink.
 #
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Copy;
 use File::Path qw(rmtree);
 use PostgreSQL::Test::Utils;

src/bin/pg_rewind/t/005_same_timeline.pl

@@ -6,7 +6,7 @@
 # on the same timeline runs successfully.
 #
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_rewind/t/006_options.pl

@@ -5,7 +5,7 @@
 # Test checking options of pg_rewind.
 #
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_rewind/t/007_standby_source.pl

@@ -25,7 +25,7 @@
 # as is.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_rewind/t/008_min_recovery_point.pl

@@ -31,7 +31,7 @@
 # nodes.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

src/bin/pg_rewind/t/009_growing_files.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_rewind/t/RewindTest.pm

@@ -32,7 +32,7 @@ package RewindTest;
 # to run psql against the primary and standby servers, respectively.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use Carp;
 use Exporter 'import';

src/bin/pg_test_fsync/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Utils;
 use Test::More;

src/bin/pg_test_timing/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Utils;
 use Test::More;

src/bin/pg_upgrade/t/001_basic.pl

@@ -1,7 +1,7 @@
 # Copyright (c) 2022-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use PostgreSQL::Test::Utils;
 use Test::More;

src/bin/pg_upgrade/t/002_pg_upgrade.pl

@@ -2,7 +2,7 @@
 
 # Set of tests for pg_upgrade, including cross-version checks.
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use Cwd            qw(abs_path);
 use File::Basename qw(dirname);

src/bin/pg_upgrade/t/003_logical_slots.pl

@@ -3,7 +3,7 @@
 # Tests for upgrading logical replication slots
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 
 use File::Find qw(find);
 

src/bin/pg_verifybackup/t/001_basic.pl

@@ -2,7 +2,7 @@
 # Copyright (c) 2021-2023, PostgreSQL Global Development Group
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Utils;
 use Test::More;
 

src/bin/pg_verifybackup/t/002_algorithm.pl

@@ -4,7 +4,7 @@
 # Verify that we can take and verify backups with various checksum types.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Path qw(rmtree);
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_verifybackup/t/003_corruption.pl

@@ -4,7 +4,7 @@
 # Verify that various forms of corruption are detected by pg_verifybackup.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Path qw(rmtree);
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_verifybackup/t/004_options.pl

@@ -4,7 +4,7 @@
 # Verify the behavior of assorted pg_verifybackup options.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use File::Path qw(rmtree);
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;

src/bin/pg_verifybackup/t/005_bad_manifest.pl

@@ -5,7 +5,7 @@
 # problems.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;

src/bin/pg_verifybackup/t/006_encoding.pl

@@ -4,7 +4,7 @@
 # Verify that pg_verifybackup handles hex-encoded filenames correctly.
 
 use strict;
-use warnings;
+use warnings FATAL => 'all';
 use PostgreSQL::Test::Cluster;
 use PostgreSQL::Test::Utils;
 use Test::More;