sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-07 00:02:34 -05:00
Code Issues Projects Releases Wiki Activity

Remove over-eager assertion in ExtendBufferedRelTo()

Browse Source 
The assertion checked that the size of the relation is not "too large" - but
the code is explicitly dealing with the possibility of another backend
extending the relation concurrently. In that case the new relation size could
be bigger than what the current backend needs, wrongly triggering an assertion
failure.

Unfortunately it is hard to write a reliable and affordable regression tests
for this, as a lot of concurrency is needed to encounter the bug.

Introduced in 31966b151e6a.

Reported-by: Melanie Plageman <melanieplageman@gmail.com>
This commit is contained in:
Andres Freund 2023-05-21 09:48:37 -07:00
parent bc971f4025
commit eabb22525e
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/storage/buffer/bufmgr.c
View File

@ -953,7 +953,6 @@ ExtendBufferedRelTo(ExtendBufferedWhat eb,
buffers, &extended_by);
current_size = first_block + extended_by;
Assert(current_size <= extend_to);
Assert(num_pages != 0 || current_size >= extend_to);
for (int i = 0; i < extended_by; i++)