sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-25 00:04:05 -04:00
Code Issues Projects Releases Wiki Activity

Fix test instability introduced in e349c95d3e9 due to async deduplication.

Browse Source 
The statement emitting notifies tried to make sure page boundaries were
crossed, but failed to do so reliably due to deduplication.

Reported-By: chap@anastigmatix.net
Discussion: https://postgr.es/m/20220407185408.n7dvsgqsb3q6uze7@alap3.anarazel.de
This commit is contained in:
Andres Freund 2022-04-07 11:54:51 -07:00
parent 00cb86e75d
commit dbe29b0d2c
3 changed files with 24 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/test/isolation/expected/stats.out
View File

@ -3047,7 +3047,7 @@ step s1_slru_save_stats:
step s1_listen: LISTEN stats_test_nothing;
step s1_begin: BEGIN;
step s1_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3100,7 +3100,7 @@ step s1_slru_save_stats:
step s1_listen: LISTEN stats_test_nothing;
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3141,7 +3141,7 @@ step s1_slru_save_stats:
step s1_listen: LISTEN stats_test_nothing;
step s2_begin: BEGIN;
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3196,7 +3196,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3263,7 +3263,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3330,7 +3330,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3397,7 +3397,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3470,7 +3470,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3543,7 +3543,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3618,7 +3618,7 @@ test_stat_func| | |
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3661,7 +3661,7 @@ step s1_slru_save_stats:
step s1_listen: LISTEN stats_test_nothing;
step s1_begin: BEGIN;
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------

22
src/test/isolation/expected/stats_1.out
View File

@ -3071,7 +3071,7 @@ step s1_slru_save_stats:
step s1_listen: LISTEN stats_test_nothing;
step s1_begin: BEGIN;
step s1_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3124,7 +3124,7 @@ step s1_slru_save_stats:
step s1_listen: LISTEN stats_test_nothing;
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3165,7 +3165,7 @@ step s1_slru_save_stats:
step s1_listen: LISTEN stats_test_nothing;
step s2_begin: BEGIN;
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3220,7 +3220,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3287,7 +3287,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3354,7 +3354,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3421,7 +3421,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3494,7 +3494,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3567,7 +3567,7 @@ f
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3642,7 +3642,7 @@ test_stat_func| | |
(1 row)
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------
@ -3685,7 +3685,7 @@ step s1_slru_save_stats:
step s1_listen: LISTEN stats_test_nothing;
step s1_begin: BEGIN;
step s2_big_notify: SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
pg_notify
---------

4
src/test/isolation/specs/stats.spec
View File

@ -105,7 +105,7 @@ step s1_slru_save_stats {
}
step s1_listen { LISTEN stats_test_nothing; }
step s1_big_notify { SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
}
step s1_slru_check_stats {
@ -147,7 +147,7 @@ step s2_table_update_k1 { UPDATE test_stat_tab SET value = value + 1 WHERE key =
# SLRU stats steps
step s2_big_notify { SELECT pg_notify('stats_test_use',
repeat('0', current_setting('block_size')::int / 2)) FROM generate_series(1, 3);
repeat(i::text, current_setting('block_size')::int / 2)) FROM generate_series(1, 3) g(i);
}