From dafae9707ab7e7079ce1ba22cebda4557d0cbaf3 Mon Sep 17 00:00:00 2001 From: Thomas Munro Date: Fri, 8 Apr 2022 13:28:04 +1200 Subject: [PATCH] Fix recovery_prefetch docs. Correct a typo and a couple of sentences that weren't updated to reflect recent changes to the code. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/20220407125555.GC24419%40telsasoft.com --- doc/src/sgml/config.sgml | 5 +++-- doc/src/sgml/monitoring.sgml | 8 +++----- doc/src/sgml/wal.sgml | 2 +- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index ac533968a0c..c2c7a95a828 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -3685,8 +3685,9 @@ include_dir 'conf.d' Whether to try to prefetch blocks that are referenced in the WAL that are not yet in the buffer pool, during recovery. Valid values are - off (the default), on and - try. The setting try enables + off, on and + try (the default). The setting + try enables prefetching only if the operating system provides the posix_fadvise function, which is currently used to implement prefetching. Note that some operating systems provide the diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml index 76766d28dd4..8717df060e2 100644 --- a/doc/src/sgml/monitoring.sgml +++ b/doc/src/sgml/monitoring.sgml @@ -3049,11 +3049,9 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i The pg_stat_recovery_prefetch view will contain - only one row. It is filled with nulls if recovery has not run or - is not enabled. The - columns wal_distance, - block_distance - and io_depth show current values, and the + only one row. The columns wal_distance, + block_distance and + io_depth show current values, and the other columns show cumulative counters that can be reset with the pg_stat_reset_shared function. diff --git a/doc/src/sgml/wal.sgml b/doc/src/sgml/wal.sgml index 6b3406b7de6..4b6ef283c1c 100644 --- a/doc/src/sgml/wal.sgml +++ b/doc/src/sgml/wal.sgml @@ -812,7 +812,7 @@ The and settings limit prefetching concurrency and distance, respectively. By default, it is set to - try, which enabled the feature on systems where + try, which enables the feature on systems where posix_fadvise is available.