From cdaedfc96d1488069518d42479125ceb9a5e67d0 Mon Sep 17 00:00:00 2001 From: Nathan Bossart Date: Wed, 19 Jul 2023 15:26:52 -0700 Subject: [PATCH] Support parenthesized syntax for CLUSTER without a table name. b5913f6120 added a parenthesized syntax for CLUSTER, but it requires specifying a table name. This is unlike commands such as VACUUM and ANALYZE, which do not require specifying a table in the parenthesized syntax. This change resolves this inconsistency. This is preparatory work for a follow-up commit that will move the unparenthesized syntax to the "Compatibility" section of the CLUSTER documentation. Reviewed-by: Melanie Plageman, Michael Paquier Discussion: https://postgr.es/m/CAAKRu_bc5uHieG1976kGqJKxyWtyQt9yvktjsVX%2Bi7NOigDjOA%40mail.gmail.com --- doc/src/sgml/ref/cluster.sgml | 2 +- src/backend/parser/gram.y | 12 +++++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/doc/src/sgml/ref/cluster.sgml b/doc/src/sgml/ref/cluster.sgml index e308e2ce912..b6d5655c194 100644 --- a/doc/src/sgml/ref/cluster.sgml +++ b/doc/src/sgml/ref/cluster.sgml @@ -21,7 +21,7 @@ PostgreSQL documentation -CLUSTER [ ( option [, ...] ) ] table_name [ USING index_name ] +CLUSTER [ ( option [, ...] ) ] [ table_name [ USING index_name ] ] CLUSTER [ VERBOSE ] [ table_name [ USING index_name ] ] where option can be one of: diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y index 91793cb2eff..7a44a374e49 100644 --- a/src/backend/parser/gram.y +++ b/src/backend/parser/gram.y @@ -11553,7 +11553,7 @@ CreateConversionStmt: /***************************************************************************** * * QUERY: - * CLUSTER (options) [ USING ] + * CLUSTER (options) [ [ USING ] ] * CLUSTER [VERBOSE] [ [ USING ] ] * CLUSTER [VERBOSE] ON (for pre-8.3) * @@ -11569,6 +11569,15 @@ ClusterStmt: n->params = $3; $$ = (Node *) n; } + | CLUSTER '(' utility_option_list ')' + { + ClusterStmt *n = makeNode(ClusterStmt); + + n->relation = NULL; + n->indexname = NULL; + n->params = $3; + $$ = (Node *) n; + } /* unparenthesized VERBOSE kept for pre-14 compatibility */ | CLUSTER opt_verbose qualified_name cluster_index_specification { @@ -11581,6 +11590,7 @@ ClusterStmt: n->params = lappend(n->params, makeDefElem("verbose", NULL, @2)); $$ = (Node *) n; } + /* unparenthesized VERBOSE kept for pre-17 compatibility */ | CLUSTER opt_verbose { ClusterStmt *n = makeNode(ClusterStmt);