sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-18 00:02:37 -04:00
Code Issues Projects Releases Wiki Activity

reindexdb: Fix warning about uninitialized indices_tables_cell

Browse Source 
Initialize indices_tables_cell with NULL to silence the warning.  Also,
refactor the place of the first assignment of indices_tables_cell.

Reported-by: Thomas Munro, David Rowley, Tom Lane, Richard Guo
Discussion: https://postgr.es/m/2348025.1711332418%40sss.pgh.pa.us
Discussion: https://postgr.es/m/E1roXs4-005UdX-1V%40gemulon.postgresql.org
This commit is contained in:
Alexander Korotkov 2024-03-25 11:35:30 +02:00
parent 6190d828cd
commit cc0e7ebd30
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/bin/scripts/reindexdb.c
View File

@ -277,7 +277,7 @@ reindex_one_database(ConnParams *cparams, ReindexType type,
{ {
PGconn *conn; PGconn *conn;
SimpleStringListCell *cell; SimpleStringListCell *cell;
SimpleStringListCell *indices_tables_cell; SimpleStringListCell *indices_tables_cell = NULL;
bool parallel = concurrentCons > 1; bool parallel = concurrentCons > 1;
SimpleStringList *process_list = user_list; SimpleStringList *process_list = user_list;
SimpleStringList *indices_tables_list = NULL; SimpleStringList *indices_tables_list = NULL;
@ -366,12 +366,20 @@ reindex_one_database(ConnParams *cparams, ReindexType type,
indices_tables_list = get_parallel_object_list(conn, process_type, indices_tables_list = get_parallel_object_list(conn, process_type,
user_list, echo); user_list, echo);
if (indices_tables_list) /*
indices_tables_cell = indices_tables_list->head; * Bail out if nothing to process. 'user_list' was modified
* in-place, so check if it has at least one cell.
/* Bail out if nothing to process */ */
if (process_list == NULL) if (user_list->head == NULL)
return; return;
/*
* Assuming 'user_list' is not empty, 'indices_tables_list'
* shouldn't be empty as well.
*/
Assert(indices_tables_list != NULL);
indices_tables_cell = indices_tables_list->head;
break; break;
case REINDEX_SYSTEM: case REINDEX_SYSTEM: