sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-01 00:01:20 -04:00
Code Issues Projects Releases Wiki Activity

Don't go into infinite loop if /home/postgres/testversion/data directory is not writable.

Browse Source
This commit is contained in:
Tom Lane 2001-07-03 16:49:48 +00:00
parent 86bc2d91c3
commit c8fe66dfb2
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/backend/utils/init/miscinit.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/init/miscinit.c,v 1.72 2001/06/20 18:07:56 petere Exp $ * $Header: /cvsroot/pgsql/src/backend/utils/init/miscinit.c,v 1.73 2001/07/03 16:49:48 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -539,15 +539,18 @@ CreateLockFile(const char *filename, bool amPostmaster,
{ {
int fd; int fd;
char buffer[MAXPGPATH + 100]; char buffer[MAXPGPATH + 100];
int ntries;
int len; int len;
int encoded_pid; int encoded_pid;
pid_t other_pid; pid_t other_pid;
pid_t my_pid = getpid(); pid_t my_pid = getpid();
/* /*
* We need a loop here because of race conditions. * We need a loop here because of race conditions. But don't loop
* forever (for example, a non-writable $PGDATA directory might cause
* a failure that won't go away). 100 tries seems like plenty.
*/ */
for (;;) for (ntries = 0; ; ntries++)
{ {
/* /*
@ -560,7 +563,7 @@ CreateLockFile(const char *filename, bool amPostmaster,
/* /*
* Couldn't create the pid file. Probably it already exists. * Couldn't create the pid file. Probably it already exists.
*/ */
if (errno != EEXIST && errno != EACCES) if ((errno != EEXIST && errno != EACCES) || ntries > 100)
elog(FATAL, "Can't create lock file %s: %m", filename); elog(FATAL, "Can't create lock file %s: %m", filename);
/* /*