sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-11 00:03:02 -04:00
Code Issues Projects Releases Wiki Activity

Update outdated references to the SLRU ControlLock

Browse Source 
SLRU bank locks are referred as "bank locks" or "SLRU bank locks" in the
code comments.  The comments updated in this commit use the latter term.

Oversight in 53c2a97a9266, that has replaced the single ControlLock by
the bank control locks.

Author: Julien Rouhaud <julien.rouhaud@free.fr>
Discussion: https://postgr.es/m/aLUT2UO8RjJOzZNq@jrouhaud
Backpatch-through: 17
This commit is contained in:
Michael Paquier 2025-09-03 10:20:28 +09:00
parent 229911c4bf
commit c6ea528b47
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/access/transam/slru.c
View File

@ -400,10 +400,10 @@ SimpleLruZeroPage(SlruCtl ctl, int64 pageno)
/*
* Assume this page is now the latest active page.
*
* Note that because both this routine and SlruSelectLRUPage run with
* ControlLock held, it is not possible for this to be zeroing a page that
* SlruSelectLRUPage is going to evict simultaneously. Therefore, there's
* no memory barrier here.
* Note that because both this routine and SlruSelectLRUPage run with a
* SLRU bank lock held, it is not possible for this to be zeroing a page
* that SlruSelectLRUPage is going to evict simultaneously. Therefore,
* there's no memory barrier here.
*/
pg_atomic_write_u64(&shared->latest_page_number, pageno);
@ -437,7 +437,7 @@ SimpleLruZeroLSNs(SlruCtl ctl, int slotno)
* This is a convenience wrapper for the common case of zeroing a page and
* immediately flushing it to disk.
*
* Control lock is acquired and released here.
* SLRU bank lock is acquired and released here.
*/
void
SimpleLruZeroAndWritePage(SlruCtl ctl, int64 pageno)

2
src/include/access/slru.h
View File

@ -55,7 +55,7 @@ typedef enum
/*
* Shared-memory state
*
* ControlLock is used to protect access to the other fields, except
* SLRU bank locks are used to protect access to the other fields, except
* latest_page_number, which uses atomics; see comment in slru.c.
*/
typedef struct SlruSharedData