From be57f21650d36449ec34a67b2d9af71126a663b3 Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Mon, 7 Jun 2021 09:32:06 +0530 Subject: [PATCH] Remove two_phase variable from CreateReplicationSlotCmd struct. Commit 19890a064e added the option to enable two_phase commits via pg_create_logical_replication_slot but didn't extend the support of same in replication protocol. However, by mistake, it added the two_phase variable in CreateReplicationSlotCmd which is required only when we extend the replication protocol. Reported-by: Jeff Davis Author: Ajin Cherian Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/64b9f783c6e125f18f88fbc0c0234e34e71d8639.camel@j-davis.com --- src/backend/replication/walsender.c | 2 +- src/include/nodes/replnodes.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c index e94069c366a..109c723f4e1 100644 --- a/src/backend/replication/walsender.c +++ b/src/backend/replication/walsender.c @@ -954,7 +954,7 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd) */ ReplicationSlotCreate(cmd->slotname, true, cmd->temporary ? RS_TEMPORARY : RS_EPHEMERAL, - cmd->two_phase); + false); } if (cmd->kind == REPLICATION_KIND_LOGICAL) diff --git a/src/include/nodes/replnodes.h b/src/include/nodes/replnodes.h index ebc43a0293d..faa3a251f26 100644 --- a/src/include/nodes/replnodes.h +++ b/src/include/nodes/replnodes.h @@ -56,7 +56,6 @@ typedef struct CreateReplicationSlotCmd ReplicationKind kind; char *plugin; bool temporary; - bool two_phase; List *options; } CreateReplicationSlotCmd;