sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-31 00:03:57 -04:00
Code Issues Projects Releases Wiki Activity

Fix two problems in infer_arbiter_indexes().

Browse Source 
The first is a pretty simple bug where a relcache entry is used after
the relation is closed. In this particular situation it does not appear
to have bad consequences unless compiled with RELCACHE_FORCE_RELEASE.

The second is that infer_arbiter_indexes() skipped indexes that aren't
yet valid according to indcheckxmin. That's not required here, because
uniqueness checks don't care about visibility according to an older
snapshot.  While thats not really a bug, it makes things undesirably
non-deterministic.  There is some hope that this explains a test failure
on buildfarm member jaguarundi.

Discussion: 9096.1431102730@sss.pgh.pa.us
This commit is contained in:
Andres Freund 2015-05-08 22:22:05 +02:00
parent de7688442f
commit bab64ef9e8
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/optimizer/util/plancat.c
View File

@ -547,13 +547,11 @@ infer_arbiter_indexes(PlannerInfo *root)
goto next; goto next;
/* /*
* If the index is valid, but cannot yet be used, ignore it. See * Note that we do not perform a check against indcheckxmin (like
* src/backend/access/heap/README.HOT for discussion. * e.g. get_relation_info()) here to eliminate candidates, because
* uniqueness checking only cares about the most recently committed
* tuple versions.
*/ */
if (idxForm->indcheckxmin &&
!TransactionIdPrecedes(HeapTupleHeaderGetXmin(idxRel->rd_indextuple->t_data),
TransactionXmin))
goto next;
/* /*
* Look for match on "ON constraint_name" variant, which may not be * Look for match on "ON constraint_name" variant, which may not be
@ -566,10 +564,10 @@ infer_arbiter_indexes(PlannerInfo *root)
(errcode(ERRCODE_WRONG_OBJECT_TYPE), (errcode(ERRCODE_WRONG_OBJECT_TYPE),
errmsg("ON CONFLICT DO UPDATE not supported with exclusion constraints"))); errmsg("ON CONFLICT DO UPDATE not supported with exclusion constraints")));
candidates = lappend_oid(candidates, idxForm->indexrelid);
list_free(indexList); list_free(indexList);
index_close(idxRel, NoLock); index_close(idxRel, NoLock);
heap_close(relation, NoLock); heap_close(relation, NoLock);
candidates = lappend_oid(candidates, idxForm->indexrelid);
return candidates; return candidates;
} }
else if (indexOidFromConstraint != InvalidOid) else if (indexOidFromConstraint != InvalidOid)