mirror of
https://github.com/postgres/postgres.git
synced 2025-05-28 00:03:23 -04:00
Remove duplicate code from ReorderBufferCleanupTXN().
Andres is apparently the only hacker who thinks this code is better as-is. I (tgl) follow some of his logic, but the fact that it's setting off warnings from static code analyzers seems like a sufficient reason to put the complexity into a comment rather than the code. Aleksander Alekseev Discussion: <20160404190345.54d84ee8@fujitsu>
This commit is contained in:
parent
c7f68bea22
commit
b6182081be
@ -1158,17 +1158,15 @@ ReorderBufferCleanupTXN(ReorderBuffer *rb, ReorderBufferTXN *txn)
|
||||
txn->base_snapshot_lsn = InvalidXLogRecPtr;
|
||||
}
|
||||
|
||||
/* delete from list of known subxacts */
|
||||
if (txn->is_known_as_subxact)
|
||||
{
|
||||
/* NB: nsubxacts count of parent will be too high now */
|
||||
dlist_delete(&txn->node);
|
||||
}
|
||||
/* delete from LSN ordered list of toplevel TXNs */
|
||||
else
|
||||
{
|
||||
dlist_delete(&txn->node);
|
||||
}
|
||||
/*
|
||||
* Remove TXN from its containing list.
|
||||
*
|
||||
* Note: if txn->is_known_as_subxact, we are deleting the TXN from its
|
||||
* parent's list of known subxacts; this leaves the parent's nsubxacts
|
||||
* count too high, but we don't care. Otherwise, we are deleting the TXN
|
||||
* from the LSN-ordered list of toplevel TXNs.
|
||||
*/
|
||||
dlist_delete(&txn->node);
|
||||
|
||||
/* now remove reference from buffer */
|
||||
hash_search(rb->by_txn,
|
||||
|
Loading…
x
Reference in New Issue
Block a user