sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-09 00:05:07 -04:00
Code Issues Projects Releases Wiki Activity

Fix planner error when estimating SubPlan cost

Browse Source 
SubPlan nodes are typically built very early, before any RelOptInfos
have been constructed for the parent query level.  As a result, the
simple_rel_array in the parent root has not yet been initialized.
Currently, during cost estimation of a SubPlan's testexpr, we may call
examine_variable() to look up statistical data about the expressions.
This can lead to "no relation entry for relid" errors.

To fix, pass root as NULL to cost_qual_eval() in cost_subplan(), since
the root does not yet contain enough information to safely consult
statistics.

One exception is SubPlan nodes built for the initplans of MIN/MAX
aggregates from indexes.  In this case, having a NULL root is safe
because testexpr will be NULL.  Additionally, an initplan will by
definition not consult anything from the parent plan.

Backpatch to all supported branches.  Although the reported call path
that triggers this error is not reachable prior to v17, there's no
guarantee that other code paths -- especially in extensions -- could
not encounter the same issue when cost_qual_eval() is called with a
root that lacks a valid simple_rel_array.  The test case is not
included in pre-v17 branches though.

Bug: #19037
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Diagnosed-by: Tom Lane <tgl@sss.pgh.pa.us>
Author: Richard Guo <guofenglinux@gmail.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://postgr.es/m/19037-3d1c7bb553c7ce84@postgresql.org
Backpatch-through: 13
This commit is contained in:
Richard Guo 2025-09-03 16:00:38 +09:00
parent f2dbc83501
commit aba8f61c30
3 changed files with 44 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/backend/optimizer/path/costsize.c
View File

@ -4570,10 +4570,24 @@ cost_subplan(PlannerInfo *root, SubPlan *subplan, Plan *plan)
{
QualCost sp_cost;
/* Figure any cost for evaluating the testexpr */
/*
* Figure any cost for evaluating the testexpr.
*
* Usually, SubPlan nodes are built very early, before we have constructed
* any RelOptInfos for the parent query level, which means the parent root
* does not yet contain enough information to safely consult statistics.
* Therefore, we pass root as NULL here. cost_qual_eval() is already
* well-equipped to handle a NULL root.
*
* One exception is SubPlan nodes built for the initplans of MIN/MAX
* aggregates from indexes (cf. SS_make_initplan_from_plan). In this
* case, having a NULL root is safe because testexpr will be NULL.
* Besides, an initplan will by definition not consult anything from the
* parent plan.
*/
cost_qual_eval(&sp_cost,
make_ands_implicit((Expr *) subplan->testexpr),
root);
NULL);
if (subplan->useHashTable)
{

19
src/test/regress/expected/subselect.out
View File

@ -979,6 +979,25 @@ select (select (a.*)::text) from view_a a;
(42)
(1 row)
--
-- Test case for bug #19037: no relation entry for relid N
--
explain (costs off)
select (1 = any(array_agg(f1))) = any (select false) from int4_tbl;
QUERY PLAN
----------------------------
Aggregate
-> Seq Scan on int4_tbl
SubPlan 1
-> Result
(4 rows)
select (1 = any(array_agg(f1))) = any (select false) from int4_tbl;
?column?
----------
t
(1 row)
--
-- Check that whole-row Vars reading the result of a subselect don't include
-- any junk columns therein

9
src/test/regress/sql/subselect.sql
View File

@ -479,6 +479,15 @@ select (select view_a) from view_a;
select (select (select view_a)) from view_a;
select (select (a.*)::text) from view_a a;
--
-- Test case for bug #19037: no relation entry for relid N
--
explain (costs off)
select (1 = any(array_agg(f1))) = any (select false) from int4_tbl;
select (1 = any(array_agg(f1))) = any (select false) from int4_tbl;
--
-- Check that whole-row Vars reading the result of a subselect don't include
-- any junk columns therein