Don't crash on null input to kmip key provider

Also use the same way to compare to the empty string as everything else
around this.
This commit is contained in:
Anders Åstrand 2025-05-06 15:00:04 +02:00 committed by AndersAstrand
parent 4807e46b0b
commit aba7ce6508

View File

@ -886,10 +886,10 @@ load_kmip_keyring_provider_options(char *keyring_options)
ParseKeyringJSONOptions(KMIP_KEY_PROVIDER, (GenericKeyring *) kmip_keyring,
keyring_options, strlen(keyring_options));
if (strlen(kmip_keyring->kmip_host) == 0 ||
strlen(kmip_keyring->kmip_port) == 0 ||
strlen(kmip_keyring->kmip_ca_path) == 0 ||
strlen(kmip_keyring->kmip_cert_path) == 0)
if (kmip_keyring->kmip_host == NULL || kmip_keyring->kmip_host[0] == '\0' ||
kmip_keyring->kmip_port == NULL || kmip_keyring->kmip_port[0] == '\0' ||
kmip_keyring->kmip_ca_path == NULL || kmip_keyring->kmip_ca_path[0] == '\0' ||
kmip_keyring->kmip_cert_path == NULL || kmip_keyring->kmip_cert_path[0] == '\0')
{
ereport(WARNING,
errcode(ERRCODE_INVALID_PARAMETER_VALUE),