sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-15 00:02:24 -04:00
Code Issues Projects Releases Wiki Activity

Fix incorrect "return NULL" in BumpAllocLarge().

Browse Source 
This must be "return MemoryContextAllocationFailure(context, size, flags)"
instead.  The effect of this oversight is that if we got a malloc
failure right here, the code would act as though MCXT_ALLOC_NO_OOM
had been specified, whether it was or not.  That would likely lead
to a null-pointer-dereference crash at the unsuspecting call site.

Noted while messing with a patch to improve our Valgrind leak
detection support.  Back-patch to v17 where this code came in.
This commit is contained in:
Tom Lane 2025-05-10 20:22:39 -04:00
parent 3007fee7f2
commit a05cf22e05
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/utils/mmgr/bump.c
View File

@ -316,7 +316,7 @@ BumpAllocLarge(MemoryContext context, Size size, int flags)
block = (BumpBlock *) malloc(blksize); block = (BumpBlock *) malloc(blksize);
if (block == NULL) if (block == NULL)
return NULL; return MemoryContextAllocationFailure(context, size, flags);
context->mem_allocated += blksize; context->mem_allocated += blksize;