From 97b6f2eb759ce898ad632fd7b5db29f542b93454 Mon Sep 17 00:00:00 2001 From: Andrew Dunstan Date: Fri, 1 Mar 2019 14:11:37 -0500 Subject: [PATCH] Remove tests for pg_dumpall --exclude-database missing argument It turns out that different getopt implementations spell the error for missing arguments different ways. This test is of fairly marginal value, so instead of trying to keep up with the different error messages just remove the test. --- src/bin/pg_dump/t/001_basic.pl | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl index 59b77214c67..1dad5537398 100644 --- a/src/bin/pg_dump/t/001_basic.pl +++ b/src/bin/pg_dump/t/001_basic.pl @@ -4,7 +4,7 @@ use warnings; use Config; use PostgresNode; use TestLib; -use Test::More tests => 74; +use Test::More tests => 72; my $tempdir = TestLib::tempdir; my $tempdir_short = TestLib::tempdir_short; @@ -151,11 +151,6 @@ command_fails_like( 'pg_restore: options -C\/--create and -1\/--single-transaction cannot be used together' ); -command_fails_like( - [ 'pg_dumpall', '--exclude-database' ], - qr/\Qpg_dumpall: option '--exclude-database' requires an argument\E/, - 'pg_dumpall: option --exclude-database requires an argument'); - # also fails for -r and -t, but it seems pointless to add more tests for those. command_fails_like( [ 'pg_dumpall', '--exclude-database=foo', '--globals-only' ],