pg_createsubscriber: Fix bogus error message

Also some desultory style improvement
This commit is contained in:
Alvaro Herrera 2024-08-02 12:01:10 -04:00
parent 83737ef89c
commit 8c6ba6e6a8
No known key found for this signature in database
GPG Key ID: 1C20ACB9D5C564AE

View File

@ -1085,7 +1085,7 @@ drop_existing_subscriptions(PGconn *conn, const char *subname, const char *dbnam
if (PQresultStatus(res) != PGRES_COMMAND_OK) if (PQresultStatus(res) != PGRES_COMMAND_OK)
{ {
pg_log_error("could not drop a subscription \"%s\" settings: %s", pg_log_error("could not drop subscription \"%s\": %s",
subname, PQresultErrorMessage(res)); subname, PQresultErrorMessage(res));
disconnect_database(conn, true); disconnect_database(conn, true);
} }
@ -2083,13 +2083,13 @@ main(int argc, char **argv)
pg_log_error_hint("Try \"%s --help\" for more information.", progname); pg_log_error_hint("Try \"%s --help\" for more information.", progname);
exit(1); exit(1);
} }
pg_log_info("validating connection string on publisher"); pg_log_info("validating publisher connection string");
pub_base_conninfo = get_base_conninfo(opt.pub_conninfo_str, pub_base_conninfo = get_base_conninfo(opt.pub_conninfo_str,
&dbname_conninfo); &dbname_conninfo);
if (pub_base_conninfo == NULL) if (pub_base_conninfo == NULL)
exit(1); exit(1);
pg_log_info("validating connection string on subscriber"); pg_log_info("validating subscriber connection string");
sub_base_conninfo = get_sub_conninfo(&opt); sub_base_conninfo = get_sub_conninfo(&opt);
if (opt.database_names.head == NULL) if (opt.database_names.head == NULL)