sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-31 00:03:57 -04:00
Code Issues Projects Releases Wiki Activity

Standardize one aspect of rmgr desc output.

Browse Source 
Bring heap and hash rmgr desc output in line with nbtree and GiST desc
output by using the name latestRemovedXid for all fields that output the
contents of the latestRemovedXid field from the WAL record's C struct
(stop using local variants).

This seems like a clear improvement because latestRemovedXid is a symbol
name that already appears across many different source files, and so is
probably much more recognizable.

Discussion: https://postgr.es/m/CAH2-Wzkt_Rs4VqPSCk87nyjPAAEmWL8STU9zgET_83EF5YfrLw@mail.gmail.com
This commit is contained in:
Peter Geoghegan 2021-01-04 19:46:11 -08:00
parent cd357c7629
commit 83e3239ee7
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/rmgrdesc/hashdesc.c
View File

@ -113,7 +113,7 @@ hash_desc(StringInfo buf, XLogReaderState *record)
{
xl_hash_vacuum_one_page *xlrec = (xl_hash_vacuum_one_page *) rec;
appendStringInfo(buf, "ntuples %d, latest removed xid %u",
appendStringInfo(buf, "ntuples %d, latestRemovedXid %u",
xlrec->ntuples,
xlrec->latestRemovedXid);
break;

4
src/backend/access/rmgrdesc/heapdesc.c
View File

@ -125,7 +125,7 @@ heap2_desc(StringInfo buf, XLogReaderState *record)
{
xl_heap_clean *xlrec = (xl_heap_clean *) rec;
appendStringInfo(buf, "remxid %u", xlrec->latestRemovedXid);
appendStringInfo(buf, "latestRemovedXid %u", xlrec->latestRemovedXid);
}
else if (info == XLOG_HEAP2_FREEZE_PAGE)
{
@ -138,7 +138,7 @@ heap2_desc(StringInfo buf, XLogReaderState *record)
{
xl_heap_cleanup_info *xlrec = (xl_heap_cleanup_info *) rec;
appendStringInfo(buf, "remxid %u", xlrec->latestRemovedXid);
appendStringInfo(buf, "latestRemovedXid %u", xlrec->latestRemovedXid);
}
else if (info == XLOG_HEAP2_VISIBLE)
{