sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-04 00:02:26 -04:00
Code Issues Projects Releases Wiki Activity

Fix array allocation bugs in SetExplainExtensionState.

Browse Source 
If we already have an extension_state array but see a new extension_id
much larger than the highest the extension_id we've previously seen,
the old code might have failed to expand the array to a large enough
size, leading to disaster. Also, if we don't have an extension array
at all and need to create one, we should make sure that it's big enough
that we don't have to resize it instantly.

Reported-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: http://postgr.es/m/2949591.1758570711@sss.pgh.pa.us
Backpatch-through: 18
This commit is contained in:
Robert Haas 2025-09-25 11:43:52 -04:00
parent 507aa16125
commit 803ef0ed49
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/commands/explain_state.c
View File

@ -281,7 +281,8 @@ SetExplainExtensionState(ExplainState *es, int extension_id, void *opaque)
/* If there is no array yet, create one. */
if (es->extension_state == NULL)
{
es->extension_state_allocated = 16;
es->extension_state_allocated =
Max(16, pg_nextpower2_32(extension_id + 1));
es->extension_state =
palloc0(es->extension_state_allocated * sizeof(void *));
}
@ -291,7 +292,7 @@ SetExplainExtensionState(ExplainState *es, int extension_id, void *opaque)
{
int i;
i = pg_nextpower2_32(es->extension_state_allocated + 1);
i = pg_nextpower2_32(extension_id + 1);
es->extension_state = (void **)
repalloc0(es->extension_state,
es->extension_state_allocated * sizeof(void *),