sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-02 00:01:40 -04:00
Code Issues Projects Releases Wiki Activity

Doc: Clarify the inactive_since field description.

Browse Source 
Updated to specify that it represents the exact time a slot became
inactive, rather than the period of inactivity.

Reported-by: Peter Smith
Author: Bruce Momjian, Nisha Moond
Reviewed-by: Amit Kapila, Peter Smith
Backpatch-through: 17
Discussion: https://postgr.es/m/CAHut+PuvsyA5v8y7rYoY9mkDQzUhwaESM05yCByTMaDoRh30tA@mail.gmail.com
This commit is contained in:
Amit Kapila 2024-11-25 10:58:06 +05:30
parent 1a52069914
commit 5f46439d59
3 changed files with 19 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
doc/src/sgml/system-views.sgml
View File

@ -2397,7 +2397,7 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
<structfield>active</structfield> <type>bool</type>
</para>
<para>
True if this slot is currently actively being used
True if this slot is currently being streamed
</para></entry>
</row>
@ -2406,9 +2406,8 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
<structfield>active_pid</structfield> <type>int4</type>
</para>
<para>
The process ID of the session using this slot if the slot
is currently actively being used. <literal>NULL</literal> if
inactive.
The process ID of the session streaming data for this slot.
<literal>NULL</literal> if inactive.
</para></entry>
</row>
@ -2528,15 +2527,18 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts ppx
<structfield>inactive_since</structfield> <type>timestamptz</type>
</para>
<para>
The time since the slot has become inactive.
<literal>NULL</literal> if the slot is currently being used.
The time when the slot became inactive. <literal>NULL</literal> if the
slot is currently being streamed.
Note that for slots on the standby that are being synced from a
primary server (whose <structfield>synced</structfield> field is
<literal>true</literal>), the
<structfield>inactive_since</structfield> indicates the last
synchronization (see
<xref linkend="logicaldecoding-replication-slots-synchronization"/>)
time.
<literal>true</literal>), the <structfield>inactive_since</structfield>
indicates the time when slot synchronization (see <xref
linkend="logicaldecoding-replication-slots-synchronization"/>)
was most recently stopped. <literal>NULL</literal> if the slot
has always been synchronized. On standby, this is useful for slots
that are being synced from a primary server (whose
<structfield>synced</structfield> field is <literal>true</literal>)
so they know when the slot stopped being synchronized.
</para></entry>
</row>

2
src/backend/replication/logical/slotsync.c
View File

@ -1516,7 +1516,7 @@ update_synced_slots_inactive_since(void)
* correctly interpret the inactive_since if the standby gets promoted
* without a restart. We don't want the slots to appear inactive for a
* long time after promotion if they haven't been synchronized recently.
* Whoever acquires the slot i.e.makes the slot active will reset it.
* Whoever acquires the slot, i.e., makes the slot active, will reset it.
*/
if (!StandbyMode)
return;

6
src/include/replication/slot.h
View File

@ -202,7 +202,11 @@ typedef struct ReplicationSlot
*/
XLogRecPtr last_saved_confirmed_flush;
/* The time since the slot has become inactive */
/*
* The time when the slot became inactive. For synced slots on a standby
* server, it represents the time when slot synchronization was most
* recently stopped.
*/
TimestampTz inactive_since;
} ReplicationSlot;