Fix off-by-one bug in bitncmp(): When comparing a number of bits divisible by

8, bitncmp() may dereference a pointer one byte out of bounds.

Chris Mikkelson (bug #5101)
This commit is contained in:
Heikki Linnakangas 2009-10-08 04:46:52 +00:00
parent 595f2744b0
commit 469301e6ee

View File

@ -1,7 +1,7 @@
/* /*
* PostgreSQL type definitions for the INET and CIDR types. * PostgreSQL type definitions for the INET and CIDR types.
* *
* $PostgreSQL: pgsql/src/backend/utils/adt/network.c,v 1.56 2005/10/17 16:24:19 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/adt/network.c,v 1.56.2.1 2009/10/08 04:46:52 heikki Exp $
* *
* Jon Postel RIP 16 Oct 1998 * Jon Postel RIP 16 Oct 1998
*/ */
@ -897,7 +897,7 @@ bitncmp(void *l, void *r, int n)
b = n / 8; b = n / 8;
x = memcmp(l, r, b); x = memcmp(l, r, b);
if (x) if (x || (n % 8) == 0)
return (x); return (x);
lb = ((const u_char *) l)[b]; lb = ((const u_char *) l)[b];