From 3ab8cf92754d5ee4390af4e4840fb45d5bc25007 Mon Sep 17 00:00:00 2001 From: Andres Freund Date: Wed, 17 Apr 2024 11:21:17 -0700 Subject: [PATCH] Remove GlobalVisTestNonRemovable[Full]Horizon, not used anymore GlobalVisTestNonRemovableHorizon() was only used for the implementation of snapshot_too_old, which was removed in f691f5b80a8. As using GlobalVisTestNonRemovableHorizon() is not particularly efficient, no new uses for it should be added. Therefore remove. Discussion: https://postgr.es/m/20240415185720.q4dg4dlcyvvrabz4@awork3.anarazel.de --- src/backend/storage/ipc/procarray.c | 30 ----------------------------- src/include/utils/snapmgr.h | 2 -- 2 files changed, 32 deletions(-) diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c index 88a6d504dff..1a83c4220b2 100644 --- a/src/backend/storage/ipc/procarray.c +++ b/src/backend/storage/ipc/procarray.c @@ -4262,36 +4262,6 @@ GlobalVisTestIsRemovableXid(GlobalVisState *state, TransactionId xid) return GlobalVisTestIsRemovableFullXid(state, fxid); } -/* - * Return FullTransactionId below which all transactions are not considered - * running anymore. - * - * Note: This is less efficient than testing with - * GlobalVisTestIsRemovableFullXid as it likely requires building an accurate - * cutoff, even in the case all the XIDs compared with the cutoff are outside - * [maybe_needed, definitely_needed). - */ -FullTransactionId -GlobalVisTestNonRemovableFullHorizon(GlobalVisState *state) -{ - /* acquire accurate horizon if not already done */ - if (GlobalVisTestShouldUpdate(state)) - GlobalVisUpdate(); - - return state->maybe_needed; -} - -/* Convenience wrapper around GlobalVisTestNonRemovableFullHorizon */ -TransactionId -GlobalVisTestNonRemovableHorizon(GlobalVisState *state) -{ - FullTransactionId cutoff; - - cutoff = GlobalVisTestNonRemovableFullHorizon(state); - - return XidFromFullTransactionId(cutoff); -} - /* * Convenience wrapper around GlobalVisTestFor() and * GlobalVisTestIsRemovableFullXid(), see their comments. diff --git a/src/include/utils/snapmgr.h b/src/include/utils/snapmgr.h index 4cf79085f4d..9398a84051c 100644 --- a/src/include/utils/snapmgr.h +++ b/src/include/utils/snapmgr.h @@ -107,8 +107,6 @@ typedef struct GlobalVisState GlobalVisState; extern GlobalVisState *GlobalVisTestFor(Relation rel); extern bool GlobalVisTestIsRemovableXid(GlobalVisState *state, TransactionId xid); extern bool GlobalVisTestIsRemovableFullXid(GlobalVisState *state, FullTransactionId fxid); -extern FullTransactionId GlobalVisTestNonRemovableFullHorizon(GlobalVisState *state); -extern TransactionId GlobalVisTestNonRemovableHorizon(GlobalVisState *state); extern bool GlobalVisCheckRemovableXid(Relation rel, TransactionId xid); extern bool GlobalVisCheckRemovableFullXid(Relation rel, FullTransactionId fxid);