sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-06 00:02:36 -04:00
Code Issues Projects Releases Wiki Activity

Lobotomize test for float -Inf ^ -2, at least for now.

Browse Source 
Per POSIX this case should produce +0, but buildfarm member fossa
(with icc (ICC) 19.0.5.281 20190815) is reporting -0.  icc has a
boatload of unsafe floating-point optimizations, with a corresponding
boatload of not-too-well-documented compiler switches, and it seems our
default use of "-mp1" isn't whacking it hard enough to keep it from
misoptimizing the stanza in dpow() that checks whether y is odd.
There's nothing wrong with that code (seeing that no other buildfarm
member has trouble with it), so I'm content to blame this on the
compiler.  But without access to the compiler I'm not going to guess at
what switches might be needed to fix it.  For now, tweak the test case
so it will accept either -0 or +0 as a correct answer.

Discussion: https://postgr.es/m/E1jkyFX-0005RR-1Q@gemulon.postgresql.org
This commit is contained in:
Tom Lane 2020-06-16 15:28:37 -04:00
parent eab6e460e0
commit 3a990a1263
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/regress/expected/float8.out
View File

@ -501,10 +501,12 @@ SELECT power(float8 'inf', float8 '-inf');
0
(1 row)
SELECT power(float8 '-inf', float8 '-2');
power
-------
0
-- Intel's icc misoptimizes the code that controls the sign of this result,
-- even with -mp1. Pending a fix for that, only test for "is it zero".
SELECT power(float8 '-inf', float8 '-2') = '0';
?column?
----------
t
(1 row)
SELECT power(float8 '-inf', float8 '-3');

4
src/test/regress/sql/float8.sql
View File

@ -140,7 +140,9 @@ SELECT power(float8 'inf', float8 '-2');
SELECT power(float8 'inf', float8 '2');
SELECT power(float8 'inf', float8 'inf');
SELECT power(float8 'inf', float8 '-inf');
SELECT power(float8 '-inf', float8 '-2');
-- Intel's icc misoptimizes the code that controls the sign of this result,
-- even with -mp1. Pending a fix for that, only test for "is it zero".
SELECT power(float8 '-inf', float8 '-2') = '0';
SELECT power(float8 '-inf', float8 '-3');
SELECT power(float8 '-inf', float8 '2');
SELECT power(float8 '-inf', float8 '3');