sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-02 00:01:40 -04:00
Code Issues Projects Releases Wiki Activity

Fix unsafe use of strtol() on a non-null-terminated Text datum.

Browse Source 
jsonb_set() could produce wrong answers or incorrect error reports, or in
the worst case even crash, when trying to convert a path-array element into
an integer for use as an array subscript.  Per report from Vitaly Burovoy.
Back-patch to 9.5 where the faulty code was introduced (in commit
c6947010ceb42143).

Michael Paquier
This commit is contained in:
Tom Lane 2016-03-23 10:43:13 -04:00
parent 8320c625d9
commit 384dfbde19
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/utils/adt/jsonfuncs.c
View File

@ -3873,7 +3873,7 @@ setPathArray(JsonbIterator **it, Datum *path_elems, bool *path_nulls,
/* pick correct index */ /* pick correct index */
if (level < path_len && !path_nulls[level]) if (level < path_len && !path_nulls[level])
{ {
char *c = VARDATA_ANY(path_elems[level]); char *c = TextDatumGetCString(path_elems[level]);
long lindex; long lindex;
errno = 0; errno = 0;