sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-05 00:02:04 -04:00
Code Issues Projects Releases Wiki Activity

PG-1504 Use castNode() when casting nodes

Browse Source 
This gives us some extra protection against typos.
This commit is contained in:
Andreas Karlsson 2025-04-12 13:41:23 +02:00 committed by Andreas Karlsson
parent 090e356f4b
commit 36b17e8579
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
contrib/pg_tde/src/pg_tde_event_capture.c
View File

@ -117,12 +117,12 @@ pg_tde_ddl_command_start_capture(PG_FUNCTION_ARGS)
ereport(ERROR,
errmsg("Function can only be fired by event trigger manager"));
trigdata = (EventTriggerData *) fcinfo->context;
trigdata = castNode(EventTriggerData, fcinfo->context);
parsetree = trigdata->parsetree;
if (IsA(parsetree, IndexStmt))
{
IndexStmt *stmt = (IndexStmt *) parsetree;
IndexStmt *stmt = castNode(IndexStmt, parsetree);
Oid relationId = RangeVarGetRelid(stmt->relation, AccessShareLock, true);
validateCurrentEventTriggerState(true);
@ -152,7 +152,7 @@ pg_tde_ddl_command_start_capture(PG_FUNCTION_ARGS)
}
else if (IsA(parsetree, CreateStmt))
{
CreateStmt *stmt = (CreateStmt *) parsetree;
CreateStmt *stmt = castNode(CreateStmt, parsetree);
validateCurrentEventTriggerState(true);
tdeCurrentCreateEvent.tid = GetCurrentFullTransactionId();
@ -164,7 +164,7 @@ pg_tde_ddl_command_start_capture(PG_FUNCTION_ARGS)
}
else if (IsA(parsetree, CreateTableAsStmt))
{
CreateTableAsStmt *stmt = (CreateTableAsStmt *) parsetree;
CreateTableAsStmt *stmt = castNode(CreateTableAsStmt, parsetree);
validateCurrentEventTriggerState(true);
tdeCurrentCreateEvent.tid = GetCurrentFullTransactionId();
@ -176,7 +176,7 @@ pg_tde_ddl_command_start_capture(PG_FUNCTION_ARGS)
}
else if (IsA(parsetree, AlterTableStmt))
{
AlterTableStmt *stmt = (AlterTableStmt *) parsetree;
AlterTableStmt *stmt = castNode(AlterTableStmt, parsetree);
ListCell *lcmd;
Oid relationId = RangeVarGetRelid(stmt->relation, AccessShareLock, true);
@ -185,7 +185,7 @@ pg_tde_ddl_command_start_capture(PG_FUNCTION_ARGS)
foreach(lcmd, stmt->cmds)
{
AlterTableCmd *cmd = (AlterTableCmd *) lfirst(lcmd);
AlterTableCmd *cmd = castNode(AlterTableCmd, lfirst(lcmd));
if (cmd->subtype == AT_SetAccessMethod)
{
@ -257,14 +257,14 @@ pg_tde_ddl_command_end_capture(PG_FUNCTION_ARGS)
EventTriggerData *trigdata;
Node *parsetree;
trigdata = (EventTriggerData *) fcinfo->context;
parsetree = trigdata->parsetree;
/* Ensure this function is being called as an event trigger */
if (!CALLED_AS_EVENT_TRIGGER(fcinfo)) /* internal error */
ereport(ERROR,
errmsg("Function can only be fired by event trigger manager"));
trigdata = castNode(EventTriggerData, fcinfo->context);
parsetree = trigdata->parsetree;
if (IsA(parsetree, AlterTableStmt) && tdeCurrentCreateEvent.alterAccessMethodMode)
{
/*