sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-22 00:02:02 -04:00
Code Issues Projects Releases Wiki Activity

Suppress remaining compile warnings, and add a comment about why

Browse Source 
it's not really broken.  Andrew Dunstan
This commit is contained in:
Tom Lane 2004-11-21 22:13:37 +00:00
parent 35f4994133
commit 32c97fd58f
2 changed files with 23 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pl/plperl/SPI.xs
View File

@ -94,3 +94,7 @@ spi_spi_exec_query(query, ...)
RETVAL = newRV_noinc((SV*) ret_hash); RETVAL = newRV_noinc((SV*) ret_hash);
OUTPUT: OUTPUT:
RETVAL RETVAL
BOOT:
items = 0; /* avoid 'unused variable' warning */

22
src/pl/plperl/plperl.c
View File

@ -33,7 +33,7 @@
* ENHANCEMENTS, OR MODIFICATIONS. * ENHANCEMENTS, OR MODIFICATIONS.
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.60 2004/11/21 21:17:03 tgl Exp $ * $PostgreSQL: pgsql/src/pl/plperl/plperl.c,v 1.61 2004/11/21 22:13:37 tgl Exp $
* *
**********************************************************************/ **********************************************************************/
@ -963,9 +963,25 @@ plperl_func_handler(PG_FUNCTION_ARGS)
if (prodesc->fn_retistuple && fcinfo->resultinfo) /* set of tuples */ if (prodesc->fn_retistuple && fcinfo->resultinfo) /* set of tuples */
{ {
/*
* This branch will be taken when the function call
* appears in a context that can return a set of tuples,
* even if it only actually returns a single tuple
* (e.g. select a from foo() where foo returns a singleton
* of some composite type with member a). In this case, the
* return value will be a hashref. If a rowset is returned
* it will be an arrayref whose members will be hashrefs.
*
* Care is taken in the code only to refer to the appropriate
* one of ret_hv and ret_av, only one of which is therefore
* valid for any given call.
*
* XXX This code is in dire need of cleanup.
*/
/* SRF support */ /* SRF support */
HV *ret_hv; HV *ret_hv = NULL;
AV *ret_av; AV *ret_av = NULL;
FuncCallContext *funcctx; FuncCallContext *funcctx;
int call_cntr; int call_cntr;
int max_calls; int max_calls;