sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-12-21 00:04:11 -05:00
Code Issues Projects Releases Wiki Activity

Fix POSIX compliance in pgwin32_unsetenv() for "name" argument

Browse Source 
pgwin32_unsetenv() (compatibility routine of unsetenv() on Windows)
lacks the input validation that its sibling pgwin32_setenv() has.
Without these checks, calling unsetenv() with incorrect names crashes on
WIN32.  However, invalid names should be handled, failing on EINVAL.

This commit adds the same checks as setenv() to fail with EINVAL for a
"name" set to NULL, an empty string, or if '=' is included in the value,
per POSIX requirements.

Like 7ca37fb0406b, backpatch down to v14.  pgwin32_unsetenv() is defined
on REL_13_STABLE, but with the branch going EOL soon and the lack of
setenv() there for WIN32, nothing is done for v13.

Author: Bryan Green <dbryan.green@gmail.com>
Discussion: https://postgr.es/m/b6a1e52b-d808-4df7-87f7-2ff48d15003e@gmail.com
Backpatch-through: 14
This commit is contained in:
Michael Paquier 2025-10-21 08:05:28 +09:00
parent 4bea91f21f
commit 29b039e916
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/port/win32env.c
View File

@ -152,6 +152,13 @@ pgwin32_unsetenv(const char *name)
int res; int res;
char *envbuf; char *envbuf;
/* Error conditions, per POSIX */
if (name == NULL || name[0] == '\0' || strchr(name, '=') != NULL)
{
errno = EINVAL;
return -1;
}
envbuf = (char *) malloc(strlen(name) + 2); envbuf = (char *) malloc(strlen(name) + 2);
if (!envbuf) if (!envbuf)
return -1; return -1;