sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-14 00:03:46 -04:00
Code Issues Projects Releases Wiki Activity

Change client-side fsync_fname() to report errors fatally

Browse Source 
Given all we have learned about fsync() error handling in the last few
years, reporting an fsync() error non-fatally is not useful,
unless you don't care much about the file, in which case you probably
don't need to use fsync() in the first place.

Change fsync_fname() and durable_rename() to exit(1) on fsync() errors
other than those that we specifically chose to ignore.

This affects initdb, pg_basebackup, pg_checksums, pg_dump, pg_dumpall,
and pg_rewind.

Reviewed-by: Michael Paquier <michael@paquier.xyz>
Discussion: https://www.postgresql.org/message-id/flat/d239d1bd-aef0-ca7c-dc0a-da14bdcf0392%402ndquadrant.com
This commit is contained in:
Peter Eisentraut 2020-02-24 16:32:34 +01:00
parent a91e2fa941
commit 1420617b14
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/common/file_utils.c
View File

@ -51,8 +51,6 @@ static void walkdir(const char *path,
* fsyncing, and might not have privileges to write at all. * fsyncing, and might not have privileges to write at all.
* *
* serverVersion indicates the version of the server to be fsync'd. * serverVersion indicates the version of the server to be fsync'd.
*
* Errors are reported but not considered fatal.
*/ */
void void
fsync_pgdata(const char *pg_data, fsync_pgdata(const char *pg_data,
@ -250,8 +248,8 @@ pre_sync_fname(const char *fname, bool isdir)
* fsync_fname -- Try to fsync a file or directory * fsync_fname -- Try to fsync a file or directory
* *
* Ignores errors trying to open unreadable files, or trying to fsync * Ignores errors trying to open unreadable files, or trying to fsync
* directories on systems where that isn't allowed/required. Reports * directories on systems where that isn't allowed/required. All other errors
* other errors non-fatally. * are fatal.
*/ */
int int
fsync_fname(const char *fname, bool isdir) fsync_fname(const char *fname, bool isdir)
@ -294,9 +292,9 @@ fsync_fname(const char *fname, bool isdir)
*/ */
if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL))) if (returncode != 0 && !(isdir && (errno == EBADF || errno == EINVAL)))
{ {
pg_log_error("could not fsync file \"%s\": %m", fname); pg_log_fatal("could not fsync file \"%s\": %m", fname);
(void) close(fd); (void) close(fd);
return -1; exit(EXIT_FAILURE);
} }
(void) close(fd); (void) close(fd);
@ -364,9 +362,9 @@ durable_rename(const char *oldfile, const char *newfile)
{ {
if (fsync(fd) != 0) if (fsync(fd) != 0)
{ {
pg_log_error("could not fsync file \"%s\": %m", newfile); pg_log_fatal("could not fsync file \"%s\": %m", newfile);
close(fd); close(fd);
return -1; exit(EXIT_FAILURE);
} }
close(fd); close(fd);
} }