sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-06 00:02:36 -04:00
Code Issues Projects Releases Wiki Activity

Remove useless check for NULL subexpression.

Browse Source 
Coverity rightly gripes that it's silly to have a test here when
the adjacent ExecEvalExpr() would choke on a NULL expression pointer.

Petr Jelinek
This commit is contained in:
Tom Lane 2015-06-30 12:53:54 -04:00
parent 302ac7f271
commit 131926a52d
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/access/tablesample/tablesample.c
View File

@ -103,19 +103,13 @@ tablesample_init(SampleScanState *scanstate, TableSampleClause *tablesample)
fcinfo.argnull[1] = false; fcinfo.argnull[1] = false;
} }
/* Rest of the arguments come from user. */ /* Rest of the arguments come from user. */
i = 2; i = 2;
foreach(arg, args) foreach(arg, args)
{ {
Expr *argexpr = (Expr *) lfirst(arg); Expr *argexpr = (Expr *) lfirst(arg);
ExprState *argstate = ExecInitExpr(argexpr, (PlanState *) scanstate); ExprState *argstate = ExecInitExpr(argexpr, (PlanState *) scanstate);
if (argstate == NULL)
{
fcinfo.argnull[i] = true;
fcinfo.arg[i] = (Datum) 0;;
}
fcinfo.arg[i] = ExecEvalExpr(argstate, econtext, fcinfo.arg[i] = ExecEvalExpr(argstate, econtext,
&fcinfo.argnull[i], NULL); &fcinfo.argnull[i], NULL);
i++; i++;