sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-31 00:01:57 -04:00
Code Issues Projects Releases Wiki Activity

Don't report stats in LogicalRepApplyLoop() when in xact.

Browse Source 
pgstat_report_stat() is only supposed to be called outside of transactions. In
5891c7a8ed8 I added a pgstat_report_stat() call into LogicalRepApplyLoop()'s
timeout branch. While not commonly reached inside a transaction, it is
reachable (e.g. due to network bottlenecks or the sender being stalled / slow
for some reason).

To fix, add a !IsTransactionState() check.

No test added because there's no easy way to reproduce this case without
patching the code.

Reported-By: Erik Rijkers <er@xs4all.nl>
Discussion: https://postgr.es/m/b3463b8c-2328-dcac-0136-af95715493c1@xs4all.nl
This commit is contained in:
Andres Freund 2022-05-12 18:49:33 -07:00
parent 8d33412665
commit 0cf16cb8ca
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/replication/logical/worker.c
View File

@ -2883,9 +2883,14 @@ LogicalRepApplyLoop(XLogRecPtr last_received)
/*
* Force reporting to ensure long idle periods don't lead to
* arbitrarily delayed stats.
* arbitrarily delayed stats. Stats can only be reported outside
* of (implicit or explicit) transactions. That shouldn't lead to
* stats being delayed for long, because transactions are either
* sent as a whole on commit or streamed. Streamed transactions
* are spilled to disk and applied on commit.
*/
pgstat_report_stat(true);
if (!IsTransactionState())
pgstat_report_stat(true);
}
}