sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-27 00:05:03 -05:00
Code Issues Projects Releases Wiki Activity

Fix incorrect comment in pgstat_backend.c

Browse Source 
The counters saved from pgWalUsage, used for the difference calculations
when flushing the backend WAL stats, are updated when calling
pgstat_flush_backend() under PGSTAT_BACKEND_FLUSH_WAL, and not
pgstat_report_wal().  The comment updated in this commit referenced the
latter, but it is perfectly OK to flush the backend stats independently
of the WAL stats.

Noticed while looking at this area of the code, introduced by
76def4cdd7c2 as a copy-pasto.

Backpatch-through: 18
This commit is contained in:
Michael Paquier 2025-09-04 08:34:51 +09:00
parent e351e5c4fe
commit 09119238a1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/utils/activity/pgstat_backend.c
View File

@ -41,9 +41,9 @@ static bool backend_has_iostats = false;
/*
* WAL usage counters saved from pgWalUsage at the previous call to
* pgstat_report_wal(). This is used to calculate how much WAL usage
* happens between pgstat_report_wal() calls, by subtracting the previous
* counters from the current ones.
* pgstat_flush_backend(). This is used to calculate how much WAL usage
* happens between pgstat_flush_backend() calls, by subtracting the
* previous counters from the current ones.
*/
static WalUsage prevBackendWalUsage;