sharpetronics/PostgreSQL
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-01 00:01:20 -04:00
Code Issues Projects Releases Wiki Activity

Rename injection point for invalidation messages at end of transaction

Browse Source 
This injection point was named "AtEOXact_Inval-with-transInvalInfo", not
respecting the implied naming convention that injection points should
use lower-case characters, with terms separated by dashes.  All the
other points defined in the tree follow this style, so let's be more
consistent.

Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Aleksander Alekseev <aleksander@timescale.com>
Discussion: https://postgr.es/m/OSCPR01MB14966E14C1378DEE51FB7B7C5F5B32@OSCPR01MB14966.jpnprd01.prod.outlook.com
Backpatch-through: 17
This commit is contained in:
Michael Paquier 2025-04-22 10:01:38 +09:00
parent 5e6f9a9c4e
commit 02c63f9438
4 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/utils/cache/inval.c vendored
View File

@ -1207,7 +1207,7 @@ AtEOXact_Inval(bool isCommit)
/* Must be at top of stack */
Assert(transInvalInfo->my_level == 1 && transInvalInfo->parent == NULL);
INJECTION_POINT("AtEOXact_Inval-with-transInvalInfo");
INJECTION_POINT("transaction-end-process-inval");
if (isCommit)
{

12
src/test/modules/injection_points/expected/syscache-update-pruned.out
View File

@ -10,8 +10,8 @@ step waitprunable4: CALL vactest.wait_prunable();
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
step wakeinval4:
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_detach('transaction-end-process-inval');
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
<waiting ...>
step at2: <... completed>
step wakeinval4: <... completed>
@ -33,8 +33,8 @@ step waitprunable4: CALL vactest.wait_prunable();
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
step wakeinval4:
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_detach('transaction-end-process-inval');
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
<waiting ...>
step at2: <... completed>
step wakeinval4: <... completed>
@ -64,8 +64,8 @@ step waitprunable4: CALL vactest.wait_prunable();
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
step wakeinval4:
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_detach('transaction-end-process-inval');
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
<waiting ...>
step at2: <... completed>
step wakeinval4: <... completed>

12
src/test/modules/injection_points/expected/syscache-update-pruned_1.out
View File

@ -10,8 +10,8 @@ step waitprunable4: CALL vactest.wait_prunable();
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
step wakeinval4:
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_detach('transaction-end-process-inval');
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
<waiting ...>
step at2: <... completed>
step wakeinval4: <... completed>
@ -32,8 +32,8 @@ step waitprunable4: CALL vactest.wait_prunable();
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
step wakeinval4:
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_detach('transaction-end-process-inval');
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
<waiting ...>
step at2: <... completed>
step wakeinval4: <... completed>
@ -62,8 +62,8 @@ step waitprunable4: CALL vactest.wait_prunable();
step vac4: VACUUM (FREEZE, DISABLE_PAGE_SKIPPING) pg_class;
step grant1: GRANT SELECT ON vactest.orig50 TO PUBLIC; <waiting ...>
step wakeinval4:
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_detach('transaction-end-process-inval');
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
<waiting ...>
step at2: <... completed>
step wakeinval4: <... completed>

6
src/test/modules/injection_points/specs/syscache-update-pruned.spec
View File

@ -117,7 +117,7 @@ session s2
setup {
SELECT FROM injection_points_set_local();
SELECT FROM
injection_points_attach('AtEOXact_Inval-with-transInvalInfo', 'wait');
injection_points_attach('transaction-end-process-inval', 'wait');
}
step at2 {
CREATE TRIGGER to_set_relhastriggers BEFORE UPDATE ON vactest.orig50
@ -145,8 +145,8 @@ step wakegrant4 {
}
step at4 { ALTER TABLE vactest.child50 INHERIT vactest.orig50; }
step wakeinval4 {
SELECT FROM injection_points_detach('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_wakeup('AtEOXact_Inval-with-transInvalInfo');
SELECT FROM injection_points_detach('transaction-end-process-inval');
SELECT FROM injection_points_wakeup('transaction-end-process-inval');
}
# Witness effects of steps at2 and/or at4.
step inspect4 {