From 2e5205e379ba0edc3de2682470ba45d6146e0151 Mon Sep 17 00:00:00 2001 From: Justin Kunimune Date: Thu, 14 Dec 2023 14:08:14 -0800 Subject: [PATCH] attention to detail I went thru and corrected numerus inspection warnings. I'd say most of it is correcting typos. I also removed a bunch of unused variables and methods (and even a cupple of files), adjusted varius stylings, improved a few docstrings, made local variables where one quantity was getting calculated multiple times, and cetera. the spiciest thing was that I refatord the part where it saves a screenshot of the graphs in the MapAnalyzer; previusly it was bizzy-waiting for the GUI thread to finish taking the screenshot, which was probably fine, but now it uses FutureTask.get(), which is probably faster and definitely cleaner. I also deleted the code for the two-point equalized projection because it was bad and didn't work very well (to be precise it wasn't in use after I removed it from the projection list a few days ago so this is just codifying that renunciation). I also made AuthaGraph fixd instead of parameterized because I think that was just a mistake. --- input/Advanced/Template countries.svg | 5 +- input/Advanced/Test.svg | 1 - input/Advanced/Tissot Wikipedia +0.svg | 1 - input/Advanced/Tissot Wikipedia -20.svg | 1 - input/Basic.svg | 1 - input/Compound.svg | 1 - input/Graticule.svg | 1 - input/Orthodromes.svg | 9 +- input/Political.svg | 1 - input/{Sillouette.png => Silhouette.png} | Bin input/Simplified.svg | 1 - input/Tissot.svg | 1 - src/apps/MapAnalyzer.java | 28 +++-- src/apps/MapApplication.java | 13 +-- src/apps/MapConverter.java | 63 ++++++------ src/apps/MapEvaluator.java | 4 +- src/apps/MapExplainer.java | 10 +- src/apps/MapOptimizer.java | 12 +-- src/apps/MapPlotter.java | 2 +- src/dialogs/ProjectionSelectionDialog.java | 4 +- src/image/ImageUtils.java | 11 +- src/image/SVGMap.java | 12 +-- src/maps/CahillKeyes.java | 5 +- src/maps/Elastic.java | 8 +- src/maps/Misc.java | 4 +- src/maps/MyProjections.java | 92 ----------------- src/maps/Octahedral.java | 2 +- src/maps/Polyhedral.java | 39 +++---- src/maps/Projection.java | 72 ++++--------- src/maps/Waterman.java | 7 +- src/maps/WinkelTripel.java | 2 +- src/utils/Dixon.java | 2 +- src/utils/Math2.java | 48 +-------- src/utils/MutableDouble.java | 6 +- src/utils/SAXUtils.java | 46 --------- src/zupplemental/generate_graticule.py | 4 +- src/zupplemental/generate_orthodromes.py | 2 +- src/zupplemental/generate_political_shapes.py | 20 ++-- src/zupplemental/generate_shapes.py | 3 +- src/zupplemental/helpers.py | 96 +++++++++++------- 40 files changed, 203 insertions(+), 437 deletions(-) rename input/{Sillouette.png => Silhouette.png} (100%) delete mode 100644 src/maps/MyProjections.java delete mode 100644 src/utils/SAXUtils.java diff --git a/input/Advanced/Template countries.svg b/input/Advanced/Template countries.svg index c1437cc..ad8cf61 100644 --- a/input/Advanced/Template countries.svg +++ b/input/Advanced/Template countries.svg @@ -3,7 +3,6 @@ xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:cc="http://creativecommons.org/ns#" xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" - xmlns:svg="http://www.w3.org/2000/svg" xmlns="http://www.w3.org/2000/svg" width="2048" height="1024" @@ -15,7 +14,7 @@ Blank world map (de facto country borders) - A map of the world, showing all countries' defacto borders, with major lakes overlaid. Borders precise to 110km. Equirectangular projection. + A map of the world, showing all countries' de facto borders, with major lakes overlaid. Borders precise to 110km. Equirectangular projection.